feat: Add tags to RDS enhanced monitoring IAM role #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelM333
changed the title
|
Thanks, @SamuelM333 ! v2.20.0 has been just released. |
tomasbackman
pushed a commit
to qapital/terraform-aws-rds-aurora
that referenced
this pull request
Nov 16, 2020
attang
reviewed
Feb 5, 2021
| @@ -129,6 +129,10 @@ resource "aws_iam_role" "rds_enhanced_monitoring" { | |||
| assume_role_policy = data.aws_iam_policy_document.monitoring_rds_assume_role.json | |||
|
|
|||
| permissions_boundary = var.permissions_boundary | |||
|
|
|||
| tags = merge(var.tags, { | |||
| Name = local.name | |||
There was a problem hiding this comment.
I'm encountering an InvalidInput: Duplicate tag keys found when upgrading to 2.20+.
If name is already provided in var.tags, this would throw the duplicate error. Could this simply be tags = var.tags?
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tags to RDS enhanced monitoring IAM role.
Motivation and Context
The documentation says:
But the tags are not added to the IAM role created for RDS enhanced monitoring. This PR fixes that.
Breaking Changes
None.
How Has This Been Tested?
According to the iam_role this should work.