Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added conditional creation of RDS Aurora cluster #159

Merged
merged 8 commits into from
Oct 30, 2020

Conversation

antonbabenko
Copy link
Member

  • Added create_security_group input variable.
  • Ensure aws_iam_role and aws_iam_role_policy_attachment do not get created if create_cluster is false.
  • Update readme with conditional creation note for create_cluster use.

@antonbabenko antonbabenko changed the title pr103 conditional creation feat: Added conditional creation of RDS Aurora cluster Oct 30, 2020
@antonbabenko antonbabenko merged commit 59c1a78 into master Oct 30, 2020
@antonbabenko antonbabenko deleted the pr103-conditional-creation branch October 30, 2020 12:04
@antonbabenko
Copy link
Member Author

antonbabenko commented Oct 30, 2020

Thanks @shanedroid !

Closes #103
Closes #108

v2.29.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants