Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplify instance_parameters (Terraform 0.13) #206

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

antonbabenko
Copy link
Member

No description provided.

Copy link
Member Author

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryantbiggs If I understand the logic was broken because I could not easily specify custom instance parameters like identifier for individual instances when I had 1 instance.

I updated it to use try() and it seems like it works well in my case.

I also bumped Terraform version to 0.13 and it will be a major release. Do you agree that we can use terraform-docs 0.12 and stick to it for a while (as we discussed earlier)?

@antonbabenko antonbabenko changed the title feat: Simplify instrance_parameters (Terraform 0.13) feat: Simplify instance_parameters (Terraform 0.13) Mar 25, 2021
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sounds good to me @antonbabenko! the try() approach looks really nice as well, should be much nicer to comprehend for a lot of these nested if/count statements! 🎉

@antonbabenko antonbabenko merged commit 9ee862e into master Mar 25, 2021
@antonbabenko antonbabenko deleted the feat-simplify-instance-parameters branch March 25, 2021 14:50
@antonbabenko
Copy link
Member Author

v4.0.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants