Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify description of skip_final_snapshot variable #209

Conversation

theherk
Copy link
Contributor

@theherk theherk commented Apr 13, 2021

Description

This boolean doesn't indicate if a final snapshot should be taken but
rather it taking that snapshot should be skipped. I just hijacked the
language from the resource documentation.

Motivation and Context

The change is not required, but it is an improvement in clarity, I believe.

Breaking Changes

none

How Has This Been Tested?

Only documentation was changes.

This boolean doesn't indicate if a final snapshot should be taken but
rather it taking that snapshot should be skipped. I just hijacked the
language from the resource documentation.
@theherk theherk changed the title Clarify that this boolean is inverted. docs: Clarify that this boolean is inverted. Apr 13, 2021
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko 👍🏼 - thanks @theherk !

@antonbabenko antonbabenko changed the title docs: Clarify that this boolean is inverted. docs: Clarify description of skip_final_snapshot variable Apr 13, 2021
@antonbabenko antonbabenko merged commit 2584ebe into terraform-aws-modules:master Apr 13, 2021
@antonbabenko
Copy link
Member

Thank you!

v4.1.0 has been just released.

lsc pushed a commit to qapital/terraform-aws-rds-aurora that referenced this pull request Apr 27, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants