Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct DB instance parameter group used when users do not create one nor provide the name of existing, will use default #321

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Correct DB instance parameter group used when users do not create one nor provide the name of existing, will use default

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

…e one nor provide the name of existing, will use default
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense.

@antonbabenko antonbabenko merged commit 3a5ba14 into terraform-aws-modules:master Sep 10, 2022
antonbabenko pushed a commit that referenced this pull request Sep 10, 2022
### [7.4.2](v7.4.1...v7.4.2) (2022-09-10)

### Bug Fixes

* Correct DB instance parameter group used when users do not create one nor provide the name of existing, will use default ([#321](#321)) ([3a5ba14](3a5ba14))
@antonbabenko
Copy link
Member

This PR is included in version 7.4.2 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants