Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Variable description for master_username requirements #367

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix: Variable description for master_username requirements #367

merged 2 commits into from
Apr 10, 2023

Conversation

phillip-constantine
Copy link
Contributor

Description

Fixed variable master_username description

Motivation and Context

deployment fails if master_username is not specified, even with manage_master_user_password is true
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster#master_username

Breaking Changes

No, only the description was changed

How Has This Been Tested?

  • [* ] I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title fixed variable description for master_username requirements fix: Variable description for master_username requirements Apr 10, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit d0435c6 into terraform-aws-modules:master Apr 10, 2023
antonbabenko pushed a commit that referenced this pull request Apr 10, 2023
### [8.0.1](v8.0.0...v8.0.1) (2023-04-10)

### Bug Fixes

* Variable description for `master_username` requirements ([#367](#367)) ([d0435c6](d0435c6))
@antonbabenko
Copy link
Member

This PR is included in version 8.0.1 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants