Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add delete_automated_backups and update MSV of AWS provider to v5.26 to support #415

Merged
merged 2 commits into from
Dec 11, 2023
Merged

feat!: Add delete_automated_backups and update MSV of AWS provider to v5.26 to support #415

merged 2 commits into from
Dec 11, 2023

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Nov 23, 2023 •
edited by bryantbiggs
Loading

Description

  • Add delete_automated_backups to aws_rds_cluster.
  • Change default value for backup_retention_period from 7 to null

Motivation and Context

Breaking Changes

Yes. AWS provider version upgrade to v5.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title feat: Add delete_automated_backups and aws provider v5 upgrade feat!: Add delete_automated_backups and update MSV of AWS provider to v5.26 to support Dec 11, 2023
bryantbiggs
bryantbiggs approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change for AWS provider major version upgrade - looks great, thank you!

@bryantbiggs bryantbiggs merged commit c9e4933 into terraform-aws-modules:master Dec 11, 2023
14 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 11, 2023
@semantic-release-bot
chore(release): version 9.0.0 [skip ci]
7bf5933 
## [9.0.0](v8.5.0...v9.0.0) (2023-12-11)

### ⚠ BREAKING CHANGES

* Add `delete_automated_backups` and update MSV of AWS provider to `v5.26` to support (#415)

### Features

* Add `delete_automated_backups` and update MSV of AWS provider to `v5.26` to support ([#415](#415)) ([c9e4933](c9e4933))
@antonbabenko
Copy link
Member

This PR is included in version 9.0.0 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
@magreenbaum magreenbaum deleted the feat/delete_automated_backups branch January 24, 2024 01:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magreenbaum @antonbabenko @bryantbiggs