Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add security_group_use_name_prefix variable to enable/disable name prefix usage #289

Merged
merged 1 commit into from
May 2, 2022
Merged

feat: Add security_group_use_name_prefix variable to enable/disable name prefix usage #289

merged 1 commit into from
May 2, 2022

Conversation

naseemkullah
Copy link
Contributor

@naseemkullah naseemkullah commented May 2, 2022 •
edited
Loading

Description

Add security_group_use_name_prefix that defaults to true, which toggles wether to use name_prefix or name within the security group

Motivation and Context

name/name-prefix changes in security groups are destructive, in order to import resources to this module I need to be able to use just name and not name_prefix.

Breaking Changes

keeping name-prefix as the default does not introduce breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@naseemkullah naseemkullah force-pushed the security_group_use_name_prefix branch 2 times, most recently from b582f93 to 34b1c02 Compare May 2, 2022 17:53
@naseemkullah naseemkullah changed the title feat: add security_group_use_name_prefix variable feat: Add security_group_use_name_prefix variable May 2, 2022
@bryantbiggs
Copy link
Member

Thanks for the PR @naseemkullah ! can you please run pre-commit run -a to update the docs please

@naseemkullah naseemkullah force-pushed the security_group_use_name_prefix branch 2 times, most recently from df698b3 to 77e8c0b Compare May 2, 2022 18:05
@naseemkullah
Copy link
Contributor Author

Thanks for the PR @naseemkullah ! can you please run pre-commit run -a to update the docs please

my pleasure @bryantbiggs , done!

would it be possible to cut a release immediately upon merging?

@bryantbiggs
Copy link
Member

@naseemkullah releases are automatic after each merge

@bryantbiggs bryantbiggs changed the title feat: Add security_group_use_name_prefix variable feat: Add security_group_use_name_prefix variable to enable/disable name prefix usage May 2, 2022
@naseemkullah naseemkullah force-pushed the security_group_use_name_prefix branch from 77e8c0b to 0f386ba Compare May 2, 2022 18:16
@naseemkullah
Copy link
Contributor Author

@naseemkullah releases are automatic after each merge

Alright, perfect! Looking forward to it.

bryantbiggs
bryantbiggs approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - @antonbabenko your thoughts?

antonbabenko
antonbabenko approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it is backward-compatible, it is good.

@antonbabenko antonbabenko merged commit 75ffb30 into terraform-aws-modules:master May 2, 2022
antonbabenko pushed a commit that referenced this pull request May 2, 2022
@semantic-release-bot
chore(release): version 7.1.0 [skip ci]
ca40e23 
## [7.1.0](v7.0.0...v7.1.0) (2022-05-02)

### Features

* Add `security_group_use_name_prefix` variable to enable/disable name prefix usage ([#289](#289)) ([75ffb30](75ffb30))
@antonbabenko
Copy link
Member

This PR is included in version 7.1.0 🎉

@naseemkullah naseemkullah deleted the security_group_use_name_prefix branch May 2, 2022 19:18
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naseemkullah @bryantbiggs @antonbabenko