Hide sensitive password data from cli output

[reegnz]

Description

The password should not be printed to stdout by the cli, since it is
sensitive data.

Hiding sensitive data is a must-have when running Terraform in CD
environments. It is good practice to hide sensitive data from CI/CD logs.

See official Terraform docs for details:
https://www.terraform.io/docs/configuration/outputs.html#sensitive-suppressing-values-in-cli-output

[pierresteiner]

This make sense, but while you are at it I'd suggest also changing the generation (

terraform-aws-rds-aurora/main.tf

Line 16 in 8e758a6

resource "random_id" "master_password" {

) from random_id to random_password

[reegnz]

I believe that's a more difficult call to make: that hurts the backward compatibility of the module.

[antonbabenko]

I think we can use this pull-request for now and then implement a suggestion by @pierresteiner .

FYI random_password resource was introduced in 2.2.0 of random provider: https://github.com/terraform-providers/terraform-provider-random/blob/master/CHANGELOG.md#220-august-08-2019

[antonbabenko]

v2.12.0 has been just released with this pull-request merged.

[antonbabenko]

v2.14.0 has been just released, it support for random_password resource added.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.