Skip to content

Commit

Permalink
feat: Add SASL/SCRAM and IAM access control TCP ports for Kafka / MSK (
Browse files Browse the repository at this point in the history
  • Loading branch information
aidanmelen committed Aug 23, 2022
1 parent d999066 commit c254255
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 16 deletions.
4 changes: 2 additions & 2 deletions README.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion modules/kafka/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ No resources.
| <a name="input_auto_computed_ingress_with_self"></a> [auto\_computed\_ingress\_with\_self](#input\_auto\_computed\_ingress\_with\_self) | List of maps defining computed ingress rules with self to add automatically | `list(map(string))` | `[]` | no |
| <a name="input_auto_egress_rules"></a> [auto\_egress\_rules](#input\_auto\_egress\_rules) | List of egress rules to add automatically | `list(string)` | <pre>[<br> "all-all"<br>]</pre> | no |
| <a name="input_auto_egress_with_self"></a> [auto\_egress\_with\_self](#input\_auto\_egress\_with\_self) | List of maps defining egress rules with self to add automatically | `list(map(string))` | `[]` | no |
| <a name="input_auto_ingress_rules"></a> [auto\_ingress\_rules](#input\_auto\_ingress\_rules) | List of ingress rules to add automatically | `list(string)` | <pre>[<br> "kafka-broker-tcp",<br> "kafka-broker-tls-tcp",<br> "kafka-jmx-exporter-tcp",<br> "kafka-node-exporter-tcp"<br>]</pre> | no |
| <a name="input_auto_ingress_rules"></a> [auto\_ingress\_rules](#input\_auto\_ingress\_rules) | List of ingress rules to add automatically | `list(string)` | <pre>[<br> "kafka-broker-tcp",<br> "kafka-broker-tls-tcp",<br> "kafka-broker-tls-public-tcp",<br> "kafka-broker-sasl-scram-tcp",<br> "kafka-broker-sasl-scram-tcp",<br> "kafka-broker-sasl-iam-tcp",<br> "kafka-broker-sasl-iam-public-tcp",<br> "kafka-jmx-exporter-tcp",<br> "kafka-node-exporter-tcp"<br>]</pre> | no |
| <a name="input_auto_ingress_with_self"></a> [auto\_ingress\_with\_self](#input\_auto\_ingress\_with\_self) | List of maps defining ingress rules with self to add automatically | `list(map(string))` | <pre>[<br> {<br> "rule": "all-all"<br> }<br>]</pre> | no |
| <a name="input_auto_number_of_computed_egress_rules"></a> [auto\_number\_of\_computed\_egress\_rules](#input\_auto\_number\_of\_computed\_egress\_rules) | Number of computed egress rules to create by name | `number` | `0` | no |
| <a name="input_auto_number_of_computed_egress_with_self"></a> [auto\_number\_of\_computed\_egress\_with\_self](#input\_auto\_number\_of\_computed\_egress\_with\_self) | Number of computed egress rules to create where 'self' is defined | `number` | `0` | no |
Expand Down
2 changes: 1 addition & 1 deletion modules/kafka/auto_values.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
variable "auto_ingress_rules" {
description = "List of ingress rules to add automatically"
type = list(string)
default = ["kafka-broker-tcp", "kafka-broker-tls-tcp", "kafka-jmx-exporter-tcp", "kafka-node-exporter-tcp"]
default = ["kafka-broker-tcp", "kafka-broker-tls-tcp", "kafka-broker-tls-public-tcp", "kafka-broker-sasl-scram-tcp", "kafka-broker-sasl-scram-tcp", "kafka-broker-sasl-iam-tcp", "kafka-broker-sasl-iam-public-tcp", "kafka-jmx-exporter-tcp", "kafka-node-exporter-tcp"]
}

variable "auto_ingress_with_self" {
Expand Down
2 changes: 1 addition & 1 deletion modules/zookeeper/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ No resources.
| <a name="input_auto_computed_ingress_with_self"></a> [auto\_computed\_ingress\_with\_self](#input\_auto\_computed\_ingress\_with\_self) | List of maps defining computed ingress rules with self to add automatically | `list(map(string))` | `[]` | no |
| <a name="input_auto_egress_rules"></a> [auto\_egress\_rules](#input\_auto\_egress\_rules) | List of egress rules to add automatically | `list(string)` | <pre>[<br> "all-all"<br>]</pre> | no |
| <a name="input_auto_egress_with_self"></a> [auto\_egress\_with\_self](#input\_auto\_egress\_with\_self) | List of maps defining egress rules with self to add automatically | `list(map(string))` | `[]` | no |
| <a name="input_auto_ingress_rules"></a> [auto\_ingress\_rules](#input\_auto\_ingress\_rules) | List of ingress rules to add automatically | `list(string)` | <pre>[<br> "zookeeper-2181-tcp",<br> "zookeeper-2888-tcp",<br> "zookeeper-3888-tcp",<br> "zookeeper-jmx-tcp"<br>]</pre> | no |
| <a name="input_auto_ingress_rules"></a> [auto\_ingress\_rules](#input\_auto\_ingress\_rules) | List of ingress rules to add automatically | `list(string)` | <pre>[<br> "zookeeper-2181-tcp",<br> "zookeeper-2182-tls-tcp",<br> "zookeeper-2888-tcp",<br> "zookeeper-3888-tcp",<br> "zookeeper-jmx-tcp"<br>]</pre> | no |
| <a name="input_auto_ingress_with_self"></a> [auto\_ingress\_with\_self](#input\_auto\_ingress\_with\_self) | List of maps defining ingress rules with self to add automatically | `list(map(string))` | <pre>[<br> {<br> "rule": "all-all"<br> }<br>]</pre> | no |
| <a name="input_auto_number_of_computed_egress_rules"></a> [auto\_number\_of\_computed\_egress\_rules](#input\_auto\_number\_of\_computed\_egress\_rules) | Number of computed egress rules to create by name | `number` | `0` | no |
| <a name="input_auto_number_of_computed_egress_with_self"></a> [auto\_number\_of\_computed\_egress\_with\_self](#input\_auto\_number\_of\_computed\_egress\_with\_self) | Number of computed egress rules to create where 'self' is defined | `number` | `0` | no |
Expand Down
2 changes: 1 addition & 1 deletion modules/zookeeper/auto_values.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
variable "auto_ingress_rules" {
description = "List of ingress rules to add automatically"
type = list(string)
default = ["zookeeper-2181-tcp", "zookeeper-2888-tcp", "zookeeper-3888-tcp", "zookeeper-jmx-tcp"]
default = ["zookeeper-2181-tcp", "zookeeper-2182-tls-tcp", "zookeeper-2888-tcp", "zookeeper-3888-tcp", "zookeeper-jmx-tcp"]
}

variable "auto_ingress_with_self" {
Expand Down
26 changes: 16 additions & 10 deletions rules.tf
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,15 @@ variable "rules" {
ipsec-500-udp = [500, 500, "udp", "IPSEC ISAKMP"]
ipsec-4500-udp = [4500, 4500, "udp", "IPSEC NAT-T"]
# Kafka
kafka-broker-tcp = [9092, 9092, "tcp", "Kafka broker 0.8.2+"]
kafka-broker-tls-tcp = [9094, 9094, "tcp", "Kafka TLS enabled broker 0.8.2+"]
kafka-jmx-exporter-tcp = [11001, 11001, "tcp", "Kafka JMX Exporter"]
kafka-node-exporter-tcp = [11002, 11002, "tcp", "Kafka Node Exporter"]
kafka-broker-tcp = [9092, 9092, "tcp", "Kafka PLAINTEXT enable broker 0.8.2+"]
kafka-broker-tls-tcp = [9094, 9094, "tcp", "Kafka TLS enabled broker 0.8.2+"]
kafka-broker-tls-public-tcp = [9194, 9194, "tcp", "Kafka TLS Public enabled broker 0.8.2+ (MSK specific)"]
kafka-broker-sasl-scram-tcp = [9096, 9096, "tcp", "Kafka SASL/SCRAM enabled broker (MSK specific)"]
kafka-broker-sasl-scram-public-tcp = [9196, 9196, "tcp", "Kafka SASL/SCRAM Public enabled broker (MSK specific)"]
kafka-broker-sasl-iam-tcp = [9098, 9098, "tcp", "Kafka SASL/IAM access control enabled (MSK specific)"]
kafka-broker-sasl-iam-public-tcp = [9198, 9198, "tcp", "Kafka SASL/IAM Public access control enabled (MSK specific)"]
kafka-jmx-exporter-tcp = [11001, 11001, "tcp", "Kafka JMX Exporter"]
kafka-node-exporter-tcp = [11002, 11002, "tcp", "Kafka Node Exporter"]
# Kibana
kibana-tcp = [5601, 5601, "tcp", "Kibana Web Interface"]
# Kubernetes
Expand Down Expand Up @@ -188,10 +193,11 @@ variable "rules" {
zipkin-query-tcp = [9411, 9411, "tcp", "Zipkin query port"]
zipkin-web-tcp = [8080, 8080, "tcp", "Zipkin web port"]
# Zookeeper
zookeeper-2181-tcp = [2181, 2181, "tcp", "Zookeeper"]
zookeeper-2888-tcp = [2888, 2888, "tcp", "Zookeeper"]
zookeeper-3888-tcp = [3888, 3888, "tcp", "Zookeeper"]
zookeeper-jmx-tcp = [7199, 7199, "tcp", "JMX"]
zookeeper-2181-tcp = [2181, 2181, "tcp", "Zookeeper"]
zookeeper-2182-tls-tcp = [2182, 2182, "tcp", "Zookeeper TLS (MSK specific)"]
zookeeper-2888-tcp = [2888, 2888, "tcp", "Zookeeper"]
zookeeper-3888-tcp = [3888, 3888, "tcp", "Zookeeper"]
zookeeper-jmx-tcp = [7199, 7199, "tcp", "JMX"]
# Open all ports & protocols
all-all = [-1, -1, "-1", "All protocols"]
all-tcp = [0, 65535, "tcp", "All TCP ports"]
Expand Down Expand Up @@ -290,7 +296,7 @@ variable "auto_groups" {
egress_rules = ["all-all"]
}
kafka = {
ingress_rules = ["kafka-broker-tcp", "kafka-broker-tls-tcp", "kafka-jmx-exporter-tcp", "kafka-node-exporter-tcp"]
ingress_rules = ["kafka-broker-tcp", "kafka-broker-tls-tcp", "kafka-broker-tls-public-tcp", "kafka-broker-sasl-scram-tcp", "kafka-broker-sasl-scram-tcp", "kafka-broker-sasl-iam-tcp", "kafka-broker-sasl-iam-public-tcp", "kafka-jmx-exporter-tcp", "kafka-node-exporter-tcp"]
ingress_with_self = ["all-all"]
egress_rules = ["all-all"]
}
Expand Down Expand Up @@ -470,7 +476,7 @@ variable "auto_groups" {
egress_rules = ["all-all"]
}
zookeeper = {
ingress_rules = ["zookeeper-2181-tcp", "zookeeper-2888-tcp", "zookeeper-3888-tcp", "zookeeper-jmx-tcp"]
ingress_rules = ["zookeeper-2181-tcp", "zookeeper-2182-tls-tcp", "zookeeper-2888-tcp", "zookeeper-3888-tcp", "zookeeper-jmx-tcp"]
ingress_with_self = ["all-all"]
egress_rules = ["all-all"]
}
Expand Down

0 comments on commit c254255

Please sign in to comment.