Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ingress_with_prefix_list_ids and egress_with_prefix_list_ids #224

Closed
arielsalvo opened this issue Jul 27, 2021 · 7 comments
Closed
Labels

Comments

@arielsalvo
Copy link

Is your request related to a new offering from AWS?

This would be a missing use case related to the already implemented ingress_prefix_list_ids and egress_prefix_list_ids

Is your request related to a problem? Please describe.

In order to create rules with different combinations of prefix_lists and ports in the same SG, I had to create rule-only modules and I even had to use ingress_with_self to create a rule for a custom port.

Describe the solution you'd like.

The solution would be to implement something very similar to what is already implemented for other types of rules (e.g. ingress_with_cidr_blocks or ingress_with_source_security_group_id

Describe alternatives you've considered.

As stated before, I created rule-only instances of the module to group by ports and prefix lists so that each prefix list can be granted access to the appropriate ports. i.e. list_A would have access to ports 443 and 22, and list_B only to port 443.

Additional context

This is probably related to Issues #131 and #158 .

schniber pushed a commit to schniber/terraform-aws-security-group that referenced this issue Aug 31, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 11, 2022
@github-actions
Copy link

This issue was automatically closed because of stale in 10 days

@arielsalvo
Copy link
Author

This is still missing and shouldn't be closed

@simoferr98
Copy link

simoferr98 commented Feb 17, 2022

I find myself in the same situation.

@michaelallcloud
Copy link

Same here

@davcen
Copy link

davcen commented May 26, 2022

Same problem here

andyshinn pushed a commit to andyshinn/terraform-aws-security-group that referenced this issue Sep 15, 2022
andyshinn pushed a commit to andyshinn/terraform-aws-security-group that referenced this issue Sep 20, 2022
andyshinn pushed a commit to andyshinn/terraform-aws-security-group that referenced this issue Oct 21, 2022
andyshinn pushed a commit to andyshinn/terraform-aws-security-group that referenced this issue Oct 21, 2022
andyshinn pushed a commit to andyshinn/terraform-aws-security-group that referenced this issue Nov 9, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants