Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call try to retrieve tgw_id #12

Conversation

everops-kevin
Copy link

Description

Aims to fix #11, where attaching VPCs but not creating the TGW will fail.
Check for tgw_id on line 70 using terraform's try function so that the lookup's default doesn't break it.

Motivation and Context

See #11

Breaking Changes

Nope

How Has This Been Tested?

Tested on my environment with and without creating TGW, it works for me.

@everops-kevin everops-kevin changed the title call try to retrieve tgw_id fix: call try to retrieve tgw_id Apr 22, 2020
@everops-kevin
Copy link
Author

I misunderstood the purpose of using var.tgw_id with RAM sharing

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making VPC Attachments without creating TGW fails
1 participant