Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request - VPN Gateway #22

Closed
bcenker opened this issue Nov 6, 2017 · 3 comments
Closed

Feature request - VPN Gateway #22

bcenker opened this issue Nov 6, 2017 · 3 comments

Comments

@bcenker
Copy link
Contributor

bcenker commented Nov 6, 2017

I see there is a separate repo for terraform-aws-vpn-gateway - would it make sense to include the vpn gateway in the vpc module, given that is is managed under the VPC console and a vpn gateway would only be created within a VPC? I haven't been able to think of a scenario where a vpn gateway resource would be created outside the scope of the vpc it was going to be attached to. Route-table-propagation could then be refactored as a true/false flag instead of having to define a vpn gateway elsewhere and pass it in as a variable. I can submit a PR for this if it makes sense.
@antonbabenko
Copy link
Member

Yes, it makes sense to be included into this VPC module. This is the code we've from before - https://github.com/terraform-community-modules/tf_aws_vpn_gw

PS: Earlier today I have written a list of things to consider when implementing VPC log feature. It is pretty similar to the one needed for VPN Gateway.

It would be awesome if you can work on it. Let me know if you have other questions.

@antonbabenko antonbabenko changed the title Thoughts on including VPN Gateway resource? Feature request - VPN Gateway Nov 11, 2017
bcenker pushed a commit to bcenker/terraform-aws-vpc that referenced this issue Nov 11, 2017
terraform-aws-modules#22 add vpn gateway feature
13f8fbf
bcenker pushed a commit to bcenker/terraform-aws-vpc that referenced this issue Nov 11, 2017
terraform-aws-modules#22 add vpn gateway feature
dc02758
antonbabenko pushed a commit that referenced this issue Nov 11, 2017
@bcenker @antonbabenko
#22 add vpn gateway feature (#24)
9bc4844
@antonbabenko
Copy link
Member

Done in v1.1.0. Thanks @bcenker

ChairmanTubeAmp pushed a commit to Shapeways/terraform-aws-vpc that referenced this issue Nov 28, 2017
Merge branch 'master' of github.com:Shapeways/terraform-aws-vpc
3a3fee4 
* 'master' of github.com:Shapeways/terraform-aws-vpc:
  Reverted bad merge, fixed terraform-aws-modules#33
  Set enable_dns_support=true by default
  Updated descriptions for DNS variables (closes terraform-aws-modules#14)
  Add version requirements in README.md (fixes terraform-aws-modules#32)
  Add version requirements in README.md
  make sure outputs are always valid (terraform-aws-modules#29)
  Add tags to the aws_vpc_dhcp_options resource (terraform-aws-modules#30)
  Add support for DHCP options set (terraform-aws-modules#20)
  terraform-aws-modules#22 add vpn gateway feature (terraform-aws-modules#24)
  Add cidr_block outputs to public and private subnets (terraform-aws-modules#19)
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antonbabenko @bcenker