Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding output for private natgateway #1042

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tommoatki1994
Copy link

@tommoatki1994 tommoatki1994 commented Feb 5, 2024

Description

feat: Adding output using private natgateway

Motivation and Context

fixes minor issue

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@tommoatki1994 tommoatki1994 changed the title Adding additional ip's feat: Adding output for private natgateway Feb 5, 2024
Copy link

@hammy414 hammy414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be very helpful to come up to date with the pub VPC features.

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 30, 2024
@Smana
Copy link

Smana commented Apr 2, 2024

tf-controller plan output:

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

To apply this plan, please merge this pull request.

@github-actions github-actions bot removed the stale label Apr 3, 2024

output "private_nat_gateway_ips" {
description = "List of private nat gateway ip's"
value = aws_nat_gateway.this[*].private_nat_gateway_private_ips
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not appear to be a valid attribute - where are you seeing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants