Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable dynamodb data source when not needed #6

Merged
merged 1 commit into from
Sep 27, 2017

Conversation

mgresko
Copy link

@mgresko mgresko commented Sep 27, 2017

dynamodb is not supported in govcloud so this module will always fail to run. Setting count to false allows this to run correctly.

@antonbabenko
Copy link
Member

Thanks for the code. Are you sure that DynamoDB is not supported in GovCloud? Could you try it with this module?

According to AWS documentation DynamoDB is actually supported in GovCloud, but I agree to turn it on/off should be optional.

@antonbabenko antonbabenko merged commit bd175b0 into terraform-aws-modules:master Sep 27, 2017
@mgresko
Copy link
Author

mgresko commented Sep 28, 2017

@antonbabenko here is the issue... Govcloud supports DynamoDB however it does not have support for dynamodb vpc endpoint. Fix is still valid just slightly different reasoning. :)

Error refreshing state: 1 error(s) occurred:

* module.vpc.data.aws_vpc_endpoint_service.dynamodb: 1 error(s) occurred:

* module.vpc.data.aws_vpc_endpoint_service.dynamodb: data.aws_vpc_endpoint_service.dynamodb: VPC Endpoint Service (dynamodb) not found

I also confirmed through AWS consul that you can't create a dynamodb vpc endpoint.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants