Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parameter cidr_block set to null if use_ipam_pool set to true #911

Closed
wants to merge 1 commit into from

Conversation

osaluden
Copy link

Description

cidr_block parameter is set to null when use_ipam_pool varaiable is set to true. Thus, only ipv4_netmask_length is available when you want to use IPAM. However, it is possible to chose the CIDR rather than the netmask length as the example shows at line 44.

Motivation and Context

Want to be able to use IPAM with CIDR selection, not only with netmask length selection.

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • Test with cidr provisioned as example shows at line 44
  • Test with ipv4_netmask_length provisioned as example shows at line 24
  • Test with use_ipam_pool set to false
  • I have executed pre-commit run -a on my pull request

@osaluden osaluden changed the title Fix cidr_block set to null if use_ipam_pool set to true fix: cidr_block set to null if use_ipam_pool set to true Mar 15, 2023
@osaluden osaluden changed the title fix: cidr_block set to null if use_ipam_pool set to true fix: Parameter cidr_block set to null if use_ipam_pool set to true Mar 15, 2023
@osaluden
Copy link
Author

Hi there

After several tests an deployment, I discovered that if the parameter use_ipam_pool is set to false, it is still possible to use the ipv4_ipam_pool_id parameter to register the VPC CIDR into the desired IPAM pool. This way, the cidr parameter can be used as well as ipv4_netmask_length if you want to ask IPAM to provided you with a CIDR range with the desired netmask length.

Let's close the pull request.

@osaluden osaluden closed this Mar 22, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant