Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update number of route tables in intra subnets to match num AZs #949

Conversation

megashby
Copy link

@megashby megashby commented Jun 7, 2023

Description

Create one route table and associated route table association per subnet for intra subnets

Motivation and Context

We need to deploy lambdas in a VPC that has both private subnet and intra subnet tiers. Our use case is some lambdas will need to be able to connect to the internet via NATGWs, but some lambdas won't need any outbound internet access. For lambdas that will be deployed in the intra subnets, they will be in multiple AZs and the current pattern of only having one route table shared amongst all subnets is not compatible with patterns like having VPC endpoints / private link endpoints deployed in all subnets.

Breaking Changes

No, outputs for intra_subnets_route_table_ids and intra_subnets_route_table_association_ids will now potentially have more than 1 output.

How Has This Been Tested?

  • [ x ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ x ] I have tested and validated these changes using one or more of the provided examples/* projects

Running complete and separate-route-tables examples show that 3 route tables are now being created.

Screenshot 2023-06-07 at 2 31 17 PM

  • [ x ] I have executed pre-commit run -a on my pull request

@megashby megashby changed the title update the number of route tables in intra subnets to allow AZ deploy… fix: update number of route tables in intra subnets to match num AZs Jun 7, 2023
@megashby megashby closed this Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant