✨ #42 Add support for provisioning only a single NAT Gateway #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with enable_nat_gateway input
🐛 terraform-community-modules#47 Fix issue with string vs bool value with enable_nat_gateway input
n8io
changed the title
n8io
changed the title
|
You may want to update the README to clarify what these parameters do, too. |
…single NAT Gateway
n8io
force-pushed
the
feature/allow-single-nat-gateway
branch
from
ed802eb
to
4c86823
Compare
|
@tfhartmann Good catch. Done. |
n8io
changed the title
|
@antonbabenko this PR is ready for review/merge. |
|
The code looks good to me. I will merge it and tag a release, but unfortunately I won't be able to test it myself in the nearest future. If there are any issues with this module - open an issue (cc: all). |
|
No worries @antonbabenko. Thank you for all the great work leading up to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPENDENT ON PR #57(merged)Sample setup:
Scenario 1 (high availability)
Prior to this change when you set
enable_nat_gateway=trueyou would get the following infrastructure:While this follows high availability best practices and should be your configuration in a production, sometimes you don't want to incur the cost of having multiple NAT gateways in your dev and testing environments.
Scenario 2 (low availability)
After this change when you set
enable_nat_gateway=trueandsingle_nat_gateway=trueyou would get the following infrastructure:Meaning that you share a single EIP/NAT gateway pairing across all of your private subnets. Reducing costs while maintaining functionality but being far less available. This leaves the onus on the person terraforming to decide whether or not they are ok with the cost/risk tradeoff.
Again, this scenario is not intended for a production environment.