Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give values priority over metadata on When its key is value #451

Merged
merged 5 commits into from Feb 8, 2021
Merged

Give values priority over metadata on When its key is value #451

merged 5 commits into from Feb 8, 2021

Conversation

Kudbettin
Copy link
Member

@Kudbettin Kudbettin commented Jan 22, 2021 •
edited

Addresses #394

Give values priority over metadata When its property does not have something

@Kudbettin Kudbettin added the bug label Jan 22, 2021
@Kudbettin Kudbettin marked this pull request as ready for review January 22, 2021 19:46
eerkunt
eerkunt requested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@eerkunt eerkunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is great, but I have a feeling same functionality must apply to all other steps, right ?

So just changing one could be a bit dangerous for the end-user.

CHANGELOG.md Outdated Show resolved Hide resolved
@eerkunt eerkunt merged commit a545265 into master Feb 8, 2021
@eerkunt eerkunt deleted the fix_issue-394 branch February 8, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerkunt eerkunt eerkunt approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kudbettin @eerkunt