Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/issue 53 #55

Merged
merged 3 commits into from
Jan 12, 2019
Merged

Bug/issue 53 #55

merged 3 commits into from
Jan 12, 2019

Conversation

eerkunt
Copy link
Member

@eerkunt eerkunt commented Jan 12, 2019

This addresses the problem defined in #53.

change_value_in_dict() function should be called on different cases, it should not be called on some variables that has mathematical operations/conditions on it. This PR addresses that issue.

Thanks to @dginther for reporting the problem!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 185

  • 6 of 11 (54.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 81.043%

Changes Missing Coverage Covered Lines Changed/Added Lines %
terraform_compliance/common/helper.py 5 10 50.0%
Totals Coverage Status
Change from base Build 181: 1.6%
Covered Lines: 342
Relevant Lines: 422

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 185

  • 6 of 11 (54.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 81.043%

Changes Missing Coverage Covered Lines Changed/Added Lines %
terraform_compliance/common/helper.py 5 10 50.0%
Totals Coverage Status
Change from base Build 181: 1.6%
Covered Lines: 342
Relevant Lines: 422

💛 - Coveralls

@eerkunt eerkunt merged commit 0510a6b into master Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants