-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option --with-aggregate-type-defaults to enable printing of default values for types 'list' and 'map'. #53
Add option --with-aggregate-type-defaults to enable printing of default values for types 'list' and 'map'. #53
Conversation
…lt values are presented as JSON.
@yields with the number of pull requests being open since a longer time now, is this project still maintained? |
We use it heavily in segment, however, since I've moved teams I no longer personally use this. |
I think it's a wonderful tool and at @getcloudnative, we plan to make heavy use of it as well. Let me know if you want to welcome an additional maintainer. |
@boggsboggs I am referring to your recent commit 7110697, indicating that this repo is currently unmaintained. I am willing to step in as a maintainer or have maintenance transferred over to https://github.com/getcloudnative/terraform-docs. Please let me know if either works for you. |
@metmajer I'd love to take you up on your offer to become a maintainer for this project. I need to talk to legal and security here to see what process I need to follow to add you as a collaborator on the project. That's taking a little while... thanks for your patience. |
Thanks for your patience @metmajer. You're a collaborator with write access to the repo now. I've updated the Readme to reference you and your work and explain the maintenance arrangement to users: https://github.com/segmentio/terraform-docs#maintenance |
@boggsboggs Thanks for making this happen. In order to properly maintain this project for @segmentio, I request admin access to this repository so that I can enlarge the maintenance team if needed. You can reach out to me via metmajer@getcloudnative.io. Thanks! |
…lt values for types 'list' and 'map'.
Prerequisites
Put an
x
into the box(es) that apply:For more information, see the Contributing Guide.
Description
This pull request adds the
--with-aggregate-type-defaults
option to enable printing of default values for types 'list' and 'map'. If enabled, default values of aggregate types are presented as JSON data structures.The pull request introduces a breaking change. The data type
doc.Value
has its propertyLiteral
changed toValue
. This shouldn't affect you're making use ofterraform-docs json
, where this change is reflected in the resulting output.The following example shows the processing of a Terraform variable of type
map
:{ "bar": 1, "baz": "two" }
Issues Resolved
Checklist
Put an
x
into all boxes that apply:Tests
make test
.Documentation
Code Style