Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for BigQuery dataset #41

Closed
ocervell opened this issue Oct 22, 2019 · 8 comments
Closed

Add options for BigQuery dataset #41

ocervell opened this issue Oct 22, 2019 · 8 comments
Assignees

Comments

@ocervell
Copy link

Customers asked for 2 options:

  • Set the table retention period for BigQuery dataset
  • Create views while creating BQ dataset (to split prod / nonprod data for instance)
@kopachevsky kopachevsky self-assigned this Nov 4, 2019
@kopachevsky
Copy link

@ocervell can you expand second item please:

Create views while creating BQ dataset (to split prod / nonprod data for instance)

How it should looks like from user standpoint tf configuration?

@kopachevsky
Copy link

@ocervell
Copy link
Author

ocervell commented Nov 8, 2019

@kopachevsky yep sorry, I don't know how I missed it. Creating views might be useful when creating org-level log exports, for instance to segregate environments in BigQuery (if environments are burried down the Business Unit > Team stack)

@kopachevsky
Copy link

@ocervell I just can't get idea how user will define view, because for current log export module when you define bigquery destination user don't even define any bigquery tables, only dataset, so if you have in mind

@aaron-lane
Copy link
Contributor

@ocervell can you please respond?

@ocervell
Copy link
Author

ocervell commented Dec 3, 2019

You can define view in the google_bigquery_dataset resource, as shown here: https://www.terraform.io/docs/providers/google/r/bigquery_dataset.html#view.

We would need to edit the terraform-google-bigquery module, so probably need to move this issue there.

@kopachevsky
Copy link

@ocervell cat you create issue in terraform-google-bigquery please?

@aaron-lane aaron-lane transferred this issue from terraform-google-modules/terraform-google-log-export Dec 10, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 16, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 17, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 18, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 18, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 18, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 19, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 19, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 24, 2019
kopachevsky added a commit to kopachevsky/terraform-google-bigquery that referenced this issue Dec 30, 2019
@morgante
Copy link
Contributor

I believe this is now supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants