Skip to content

Commit

Permalink
feat!: hardcode create_project_sa to false (#126)
Browse files Browse the repository at this point in the history
  • Loading branch information
bharathkkb committed Oct 14, 2021
1 parent 0457e66 commit c1ee35e
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ For the cloudbuild submodule, see the README [cloudbuild](./modules/cloudbuild).
|------|-------------|------|---------|:--------:|
| activate\_apis | List of APIs to enable in the seed project. | `list(string)` | <pre>[<br> "serviceusage.googleapis.com",<br> "servicenetworking.googleapis.com",<br> "compute.googleapis.com",<br> "logging.googleapis.com",<br> "bigquery.googleapis.com",<br> "cloudresourcemanager.googleapis.com",<br> "cloudbilling.googleapis.com",<br> "iam.googleapis.com",<br> "admin.googleapis.com",<br> "appengine.googleapis.com",<br> "storage-api.googleapis.com",<br> "monitoring.googleapis.com"<br>]</pre> | no |
| billing\_account | The ID of the billing account to associate projects with. | `string` | n/a | yes |
| create\_project\_sa | Whether the default service account for the project shall be created | `bool` | `false` | no |
| default\_region | Default region to create resources where applicable. | `string` | `"us-central1"` | no |
| encrypt\_gcs\_bucket\_tfstate | Encrypt bucket used for storing terraform state files in seed project. | `bool` | `false` | no |
| folder\_id | The ID of a folder to host this project | `string` | `""` | no |
Expand Down
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ module "seed_project" {
org_id = local.seed_org_depends_on
billing_account = var.billing_account
activate_apis = local.activate_apis
create_project_sa = var.create_project_sa
create_project_sa = false
labels = var.project_labels
}

Expand Down
5 changes: 0 additions & 5 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,3 @@ variable "kms_prevent_destroy" {
description = "Set the prevent_destroy lifecycle attribute on keys."
default = true
}

variable "create_project_sa" {
description = "Whether the default service account for the project shall be created"
default = false
}

0 comments on commit c1ee35e

Please sign in to comment.