feat!: Upgrade google-project-factory to v10, add Terraform 0.13 constraint and module attribution

[bouk]

This is required to support Terraform version 0.14. It is also a
breaking change because it dropped the skip_gcloud_download variable.

[zonget]

Hi, I'm using my own fork to use this in TFC and I think it's also necessary to modify the google providers (https://github.com/zonget/terraform-google-bootstrap/commit/3555e63835c11d47a2c9cac9f96c65279bb428b9)

[rjerrems]

@bouk - I believe tests are failing because the v10.0.1 is built agains't a newer version of terraform.

Can you update the YAMLs in build/ to use this version of the image? https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/build/lint.cloudbuild.yaml#L24

[rjerrems]

This would also mean that this module is no longer terraform 12 version compatible (these are the errors I am seeing):

Warning: Provider source not supported in Terraform v0.12

  on .terraform/modules/project/modules/budget/versions.tf line 21, in terraform:
  21:     google-beta = {
  22:       source  = "hashicorp/google-beta"
  23:       version = ">= 3.43, < 4.0"
  24:     }
  

FYI @bharathkkb

[bouk]

I've bumped the tools version.

[rjerrems]

Thanks - it looks like tests are failing due to provider version mismatch of constraints:

       Error: Failed to query available provider packages
       
       Could not retrieve the list of available versions for provider
       hashicorp/google: no available releases match the given constraints ~> 3.43.0,
       ~> 3.9, >= 3.43.*, < 4.0.*, >= 3.50.*, < 4.0.*, >= 3.43.*, < 4.0.*, >= 3.43.*,
       < 4.0.*, ~> 3.5, >= 3.50.*, < 4.0.*, >= 3.43.*, < 4.0.*, >= 3.43.*, < 4.0.*,
       >= 3.43.*, < 4.0.*

FYI you can run the linting tests locally using this command make docker_test_lint which usually gives you an idea if there are any style/validation issues quickly.

[bharathkkb]

Constraints in examples like

terraform-google-bootstrap/examples/cloudbuild_enabled/main.tf

Line 19 in ae44812

version = "~> 3.43.0"

will need to be updated to >= 3.50

[rjerrems]

@bharathkkb - I have updated based on your feedback and added attribution as well.

I noticed we that I don't think we need the beta provider anymore so I also removed that. PTAL when you have a chance.

[ipv1337]

I'm finally getting around to playing catch up on these version updates.

Is there a documentation or instructions somewhere on a proper process to update our terraform foundations codebase that also uses this bootstrap module? Bootstrapping for the first time is trivial, but how do we perform upgrades to terraform in a sane manner for instance.

[morgante]

@ipv1337 We maintain a changelog which explains what has changed between versions.

The process for upgrading is just to change the version you point to and run terraform apply. Any breaking changes are noted in the changelog (and trigger a major version upgrade).

[ipv1337]

Thanks @morgante.

I'll give that a try and see how that works out on my test foundation environment. I was expecting something more complex with terraform upgrades since I thought upgrading terraform requires some manual process for upgrading the state files as well.

[bharathkkb]

I was expecting something more complex with terraform upgrades

This was a major version upgrade because we bumped min supported TF version to 0.13. You can also review the project factory 10.0 upgrade guide but should be no-op for the most part.

[ipv1337]

Great, thanks for the quick responses. I'll checkout the project factory upgrade guide as well!