-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Upgrade google-project-factory to v10, add Terraform 0.13 constraint and module attribution #81
feat!: Upgrade google-project-factory to v10, add Terraform 0.13 constraint and module attribution #81
Conversation
This is required to support Terraform version 0.14. It is also a breaking change because it dropped the `skip_gcloud_download` variable.
915d7f4
to
06b2dc5
Compare
Hi, I'm using my own fork to use this in TFC and I think it's also necessary to modify the google providers (https://github.com/zonget/terraform-google-bootstrap/commit/3555e63835c11d47a2c9cac9f96c65279bb428b9) |
@bouk - I believe tests are failing because the v10.0.1 is built agains't a newer version of terraform. Can you update the YAMLs in |
This would also mean that this module is no longer terraform 12 version compatible (these are the errors I am seeing):
FYI @bharathkkb |
I've bumped the tools version. |
Thanks - it looks like tests are failing due to provider version mismatch of constraints:
FYI you can run the linting tests locally using this command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constraints in examples like
version = "~> 3.43.0" |
will need to be updated to
>= 3.50
@bharathkkb - I have updated based on your feedback and added attribution as well. I noticed we that I don't think we need the beta provider anymore so I also removed that. PTAL when you have a chance. |
10721f7
to
0f369ce
Compare
0f369ce
to
1c0c45c
Compare
I'm finally getting around to playing catch up on these version updates. Is there a documentation or instructions somewhere on a proper process to update our terraform foundations codebase that also uses this bootstrap module? Bootstrapping for the first time is trivial, but how do we perform upgrades to terraform in a sane manner for instance. |
Thanks @morgante. I'll give that a try and see how that works out on my test foundation environment. I was expecting something more complex with terraform upgrades since I thought upgrading terraform requires some manual process for upgrading the state files as well. |
This was a major version upgrade because we bumped min supported TF version to 0.13. You can also review the project factory 10.0 upgrade guide but should be no-op for the most part. |
Great, thanks for the quick responses. I'll checkout the project factory upgrade guide as well! |
This is required to support Terraform version 0.14. It is also a
breaking change because it dropped the
skip_gcloud_download
variable.