!fix: Drop old TFV version (< v0.6.0) support
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
vovinacci
changed the title
v0.6.0) support
bharathkkb
reviewed
Dec 15, 2021
| @@ -146,7 +146,7 @@ variable "terraform_version_sha256sum" { | |||
| variable "terraform_validator_release" { | |||
| description = "Default terraform-validator release." | |||
| type = string | |||
| default = "v0.4.0" | |||
| default = "v0.6.0" | |||
There was a problem hiding this comment.
Can we add a validation rule to only support 0.6+?
| gsutil cp gs://terraform-validator/releases/${ENV_TERRAFORM_VALIDATOR_RELEASE}/terraform-validator-linux-amd64 /builder/terraform/terraform-validator && \ | ||
| TERRAFORM_VALIDATOR_VERSION=$(echo $ENV_TERRAFORM_VALIDATOR_RELEASE | sed -e 's/^v//') && \ | ||
| TERRAFORM_VALIDATOR_GCS_PATH=gs://terraform-validator/releases/${ENV_TERRAFORM_VALIDATOR_RELEASE}/terraform-validator_linux_amd64-${TERRAFORM_VALIDATOR_VERSION}.tar.gz && \ | ||
| gsutil cat "${TERRAFORM_VALIDATOR_GCS_PATH}" | tar -zxv -C /builder/terraform terraform-validator && \ |
There was a problem hiding this comment.
Can we use cp than cat? It seems like cat does not validate checksum https://cloud.google.com/storage/docs/gsutil/commands/cat#:~:text=output%20to%20stdout.)-,warning,-%3A%20The%20gsutil%20cat
There was a problem hiding this comment.
Done.
Also updated Terraform to 0.13.7 - latest in 0.13. No real changes there, just public key update.
There was a problem hiding this comment.
@bharathkkb PR review comments addressed.
bharathkkb
approved these changes
Dec 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
This PR drops support for older TFV versions (<
v0.6.0) with a breaking change.Will require updating TFV version in https://github.com/terraform-google-modules/terraform-example-foundation/blob/0ee39ceff2dce8c3a3b61d59bb1d45a4d0687e74/0-bootstrap/main.tf#L120 along with module version update.