-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lookup default value for soft delete policy #318
fix: lookup default value for soft delete policy #318
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @bharathkkb, maybe you could review this one? It's a fix related to your previous approval of #309. Thanks a lot 🙏 |
Any update on this PR? need it also :) |
any updates here? |
Would be great if this is fixed. As GCP will start billing the soft delete in September I really want to disable it for some buckets, created by this module. |
Maybe @apeabody could help run CI and approve? |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @alexandre-abrioux!
This fix is a follow up to #309
Issue
On a multi-bucket configuration, adding a
soft_delete_policy
configuration block like so:; results in the following error:
Fix
Instead of using an empty object
{}
as the default value of the lookup, we need to specify a complete object with every default value. The issue of not being able to use an empty object is described here: hashicorp/terraform#35027