Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue Argument list too long #32

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Fix for issue Argument list too long #32

merged 2 commits into from
Jul 29, 2019

Conversation

ingwarr
Copy link
Contributor

@ingwarr ingwarr commented Jul 2, 2019

Fixes #16.

@aaron-lane aaron-lane added the bug Something isn't working label Jul 2, 2019
examples/service_account/main.tf Outdated Show resolved Hide resolved
examples/service_account/main.tf Outdated Show resolved Hide resolved
@aaron-lane
Copy link
Contributor

Fixes #16

Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ingwarr since we're lacking CI at the moment, please provide some evidence that verifies this patch resolves the issue of #16.

@aaron-lane
Copy link
Contributor

Confirmed that the error seen in #16 is resolved.

@aaron-lane aaron-lane changed the base branch from aaron-lane-0.12 to master July 22, 2019 22:00
@aaron-lane aaron-lane changed the title Fix for issue Argument list too long #16 Fix for issue Argument list too long Jul 22, 2019
@aaron-lane aaron-lane self-requested a review July 22, 2019 22:03
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ingwarr can you please rebase your branch against master?

@ingwarr
Copy link
Contributor Author

ingwarr commented Jul 22, 2019

@ingwarr can you please rebase your branch against master?

Done

Copy link

@bohdanyurov-gl bohdanyurov-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits and re-run tests

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@@ -10,6 +10,10 @@ corresponding pull request appended.

## [Unreleased]

### Fixed

- Argument list too long [#32]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix issue with long argument lists.

Suggested change
- Argument list too long [#32]
- Argument list too long [#32]

@morgante morgante merged commit 8c7aada into terraform-google-modules:master Jul 29, 2019
jason-huling added a commit to jason-huling/terraform-google-iam that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data.external.additive_bindings_temp_struct: failed to execute "bash" Argument list too long
5 participants