fix: incorrect node_pools variable type
#1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`node_pool` variables are a mix of string, bool, number
therefore, it is better to use `map(any)` to indicate its type
moreover, the use of `list(map(string))` is breaking
the use of this module in `cdktf`.
in the generated code it will produce
`[]map[string]string` for `node_pools` option
but we want `[]map[string]interface{}` in order to pass correct value,
e.g. `initial_node_count` is a `number` not `string`
michaellzc
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
@michaellzc |
bharathkkb
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Thanks @michaellzc! This seems reasonable. We would likely move to a typed object with optional support at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_poolmap is a mix of string, bool, and number. therefore, it is better to usemap(any)to indicate its typemoreover,
list(map(string))is breaking the use of this module in cdktf.cdktfinfers the type of module options based on the provided variable type. in the generated code, it will produce[]map[string]stringfornode_poolsoption,but we want
[]map[string]interface{}in order to pass correct valuee.g.
initial_node_countis anumbernotstringnotes: this change is fairly safe and I did not run any integration test from this repo