-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make service range optional #1949
Labels
enhancement
New feature or request
Comments
0Delta
added a commit
to 0Delta/terraform-google-kubernetes-engine
that referenced
this issue
Jul 4, 2024
…#1949) As of GKE version 1.29 and Autopilot 1.27, the service ip range is given a default of 34.118.224.0/20 per cluster. Versions earlier than the specified version may be omitted, but will be rejected by the validator.
0Delta
added a commit
to 0Delta/terraform-google-kubernetes-engine
that referenced
this issue
Jul 4, 2024
…#1949) As of GKE version 1.29 and Autopilot 1.27, the service ip range is given a default of 34.118.224.0/20 per cluster. Versions earlier than the specified version may be omitted, but will be rejected by the validator.
I agree with this change, but I feel it needs validation. |
@0Delta I love your PR. Lets see what the maintainers think about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL;DR
There is a new default service IP range which should be used for new 1.29.3+ clusters:
GKE versions up to 1.29.2 will create a random /20 range from 10.0.0.0/8 if ip_range_services is omitted. From 1.29.3 this will set the new default service range 34.118.224.0/20 on each cluster. ( See https://cloud.google.com/kubernetes-engine/docs/release-notes#May_10_2024 )
Currently it is possible to use the new default service range by explicitly setting
var.ip_range_services
tonull
.This works for our use case, but I was wondering if you wanted this to be the default for the module in the future. I'm happy to provide a PR for this, but wanted to make sure it was something that was wanted.
Terraform Resources
Detailed design
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: