Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local-exec to be skipped #258

Closed
umairidris opened this issue Sep 6, 2019 · 2 comments · Fixed by #278
Closed

Allow local-exec to be skipped #258

umairidris opened this issue Sep 6, 2019 · 2 comments · Fixed by #278
Assignees
@paulpalamarchuk
Labels
enhancement New feature or request

Comments

@umairidris
Copy link

Some environments may not wish to have non-IaC scripts (run by provisioners like local-exec) being run in an automated way.

Where possible, these scripts should be skippable. For example:

  • resource "null_resource" "wait_for_cluster".
  • resource "null_resource" "delete_default_kube_dns_configmap"

I am happy to contribute. Would adding a new skip_provisioners bool (default to false) be an appropriate solution?
@aaron-lane aaron-lane added the enhancement New feature or request label Sep 6, 2019
@mr-smithers-excellent
Copy link

This is also an issue when running on Terraform Cloud where CLI utils gcloud and jq are not available on worker nodes. Currently, I'm unable to perform a successful apply due to the wait-for-cluster.sh script.

@morgante
Copy link
Contributor

I am happy to contribute. Would adding a new skip_provisioners bool (default to false) be an appropriate solution?

Yes, I think that can work. Thanks!

paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 8, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
4de5836 
 * Fix terraform-google-modules#258
 * Add test `simple_regional_skip_local_exec`
@paulpalamarchuk paulpalamarchuk mentioned this issue Oct 8, 2019
Merged
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 8, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
90f64f4 
 * Fix terraform-google-modules#258
 * Add test `simple_regional_skip_local_exec`
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 9, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
8263a68 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 9, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
1e6098d 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 9, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
0e0defd 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 9, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
8727e84 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 17, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
5388ada 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 17, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
e4c0861 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 17, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
dc2448d 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 17, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
c13e003 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
ce97874 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
7404493 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
198b191 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-kubernetes-engine that referenced this issue Oct 18, 2019
@paulpalamarchuk
Added variable skip_provisioners to skip 'local-exec'
9c66273 
 * Fix terraform-google-modules#258
 * Added test `simple_regional_skip_local_exec`
 * Remove old upgrading guide from README's
morgante added a commit that referenced this issue Oct 24, 2019
@morgante
Add #258
98b0690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulpalamarchuk paulpalamarchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@morgante @umairidris @mr-smithers-excellent @aaron-lane @paulpalamarchuk