Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support of google and google-beta providers to v2.0 #106

Conversation

thefirstofthe300
Copy link
Contributor

No description provided.

@thefirstofthe300 thefirstofthe300 force-pushed the ds/google-provider-2.0 branch 7 times, most recently from 8052b23 to 655b5a3 Compare March 20, 2019 22:37
@adrienthebo
Copy link
Contributor

@thefirstofthe300 could you push a fresh commit to this branch to rerun CI?

@aaron-lane aaron-lane marked this pull request as ready for review March 22, 2019 16:51
@aaron-lane aaron-lane changed the title Update the to support google and google-beta providers to v2.2 Update support of google and google-beta providers to v2.0 Mar 22, 2019
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README needs to be updated to indicate support for both providers at ~> v2.0.

@thefirstofthe300 thefirstofthe300 force-pushed the ds/google-provider-2.0 branch 2 times, most recently from 56e0609 to 44e923a Compare March 22, 2019 17:46
@aaron-lane aaron-lane dismissed their stale review March 22, 2019 18:01

README to be updated in #110

@aaron-lane
Copy link
Contributor

Fixes #27

@aaron-lane aaron-lane merged commit b4aec9b into terraform-google-modules:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants