Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Change default node image from COS to COS_CONTAINERD #1122

Merged
merged 6 commits into from
Jan 28, 2022
Merged

feat!: Change default node image from COS to COS_CONTAINERD #1122

merged 6 commits into from
Jan 28, 2022

Conversation

drthornt
Copy link
Contributor

I've changed the default image_type.

#1069

@comment-bot-dev
Copy link

comment-bot-dev commented Jan 11, 2022 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb requested changes Jan 22, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @drthornt
Since this is a breaking change we would like to include this in #1125
Could you

  • regenerate the files by running make build
  • sign the CLA

@bharathkkb bharathkkb mentioned this pull request Jan 27, 2022
Merged
@bharathkkb bharathkkb changed the title Issue 1069 Changed default node image from COS to COS_CONTAINERD feat!: Change default node image from COS to COS_CONTAINERD Jan 28, 2022
g-awmalik
g-awmalik approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb bharathkkb merged commit e6b9282 into terraform-google-modules:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb requested changes

@g-awmalik g-awmalik g-awmalik approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drthornt @comment-bot-dev @bharathkkb @g-awmalik @tripstackdavidthornton