Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/empty zone list #132

Merged

Conversation

marko7460
Copy link
Contributor

@marko7460 marko7460 commented Apr 3, 2019

This PR:

  • is the extension of Fix zone output list #64
  • fixes CI failures
  • Updates test docker image to use latest version of kitchen-terraform image as a base.

@marko7460 marko7460 marked this pull request as ready for review April 3, 2019 18:19
@aaron-lane aaron-lane mentioned this pull request Apr 3, 2019
@aaron-lane
Copy link
Contributor

Fixes #63.

Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes must be applied to the autogen files, and then the modules must be regenerated.

CHANGELOG.md Outdated
@@ -10,6 +10,7 @@ Extending the adopted spec, each change should have a link to its corresponding

## [v1.0.0] - 2019-03-25
### Added
* Fix empty zone list. [#132]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entry needs to go under a new release since 1.0.0 was already released. Since this change branch implements a complete patch, we can assume this will be released as v1.0.1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: Unreleased as there is additional content on master which must be logged.

@aaron-lane aaron-lane merged commit 00532b2 into terraform-google-modules:master Apr 4, 2019
@marko7460 marko7460 deleted the fix/empty-zone-list branch April 4, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants