Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial_node_count variable for scaling the default node pool #149

Merged

Conversation

ctrox
Copy link
Contributor

@ctrox ctrox commented May 2, 2019

Adds a variable to be able to configure the number of nodes in the default node pool. It defaults to 0 so it should not change existing behaviour.

@morgante
Copy link
Contributor

morgante commented May 2, 2019

@ctrox Is your intention to use the default node pool? We encourage explicitly passing the node pools you wish to use (via the node_pools argument on this module) and instead deleting the default node pool.

@ctrox
Copy link
Contributor Author

ctrox commented May 3, 2019

@morgante I actually want to set the initial node count to implement this workaround. But if someone really wants to use the default node pool we would need to have a lot more configuration options available, so I think this one parameter does not make it likely for someone to actually use it.

@morgante
Copy link
Contributor

morgante commented May 3, 2019

@ctrox Got it, that use case makes sense. Could we potentially compute a realistic initial_node_count based on the node_pool configs provided? Maybe you could share your expected configuration?

@ctrox
Copy link
Contributor Author

ctrox commented May 6, 2019

@morgante It might be a bit hard to compute it with Terraform 0.11 but essentially it would be just adding the min_node_count of all node pools together. With that it will launch as many nodes in the default node pool as the other pools will have afterwards. But it would also change the default behaviour of the module if for example someone did not set remove_default_node_pool = true it would suddenly launch a number of nodes.

@aaron-lane
Copy link
Contributor

Hi @ctrox.

Can you please move your implementation to the equivalent files in the autogen directory, then run make generate and make generate_docs?

@aaron-lane aaron-lane added the enhancement New feature or request label May 29, 2019
@ctrox
Copy link
Contributor Author

ctrox commented Jun 3, 2019

@aaron-lane Totally missed that, sorry! Updated my branch accordingly.

@aaron-lane aaron-lane merged commit 88f27ee into terraform-google-modules:master Jun 4, 2019
aaron-lane added a commit that referenced this pull request Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants