Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated hashicorp/template from module examples #1621

Conversation

jleloup
Copy link
Contributor

@jleloup jleloup commented Apr 28, 2023

Using the workload-identity module from an Apple M2 laptop triggers an error related to hashicorp/template being deprecated and not providing any builds for darwin_arm64.

Since the only references I can see for this provider are in some examples: I'm updating them to use the supported syntax instead.

Signed-off-by: Julien Leloup <julien.leloup@shadow.tech>
@google-cla
Copy link

google-cla bot commented Apr 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Julien Leloup and others added 2 commits April 28, 2023 15:20
@jleloup jleloup marked this pull request as ready for review April 29, 2023 07:57
@jleloup jleloup requested review from a team, Jberlinsky and ericyz as code owners April 29, 2023 07:57
@apeabody
Copy link
Contributor

apeabody commented May 8, 2023

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jleloup!

@apeabody apeabody changed the title fix: remove deprecated hashicorp/template from module examples chore: remove deprecated hashicorp/template from module examples May 10, 2023
@apeabody
Copy link
Contributor

Marking as chore as this is under examples.

@apeabody apeabody merged commit 43baaba into terraform-google-modules:master May 10, 2023
4 checks passed
@jleloup jleloup deleted the jleloup/fix-workload-identity-arm64 branch May 10, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants