Database encryption #165
Database encryption #165
Conversation
marko7460
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
marko7460
force-pushed
the
database_encryption
branch
from
7f51a01
to
5423f41
Compare
| description = "The secondary ip range to use for pods" | ||
| } | ||
|
|
||
| variable "database_encryption" { |
There was a problem hiding this comment.
Examples in this repository serve both as tangible demonstrations that users can rely on to show how functionality is utilized, and as test cases -- but primarily as demonstrations. With that in mind, it would probably be worth considering not passing this in as a variable, instead making it immediately obvious what's going on.
There was a problem hiding this comment.
I can create example but no test cases for now. Would that be sufficient?
There was a problem hiding this comment.
Adding functionality without adding tests significantly increases the failure domain of the module, and I don't think that's a risk we should be taking.
There was a problem hiding this comment.
Per conversation out of band, let's just make sure #185 is addressed once we have Terraform 0.12 compatibility, and this can be merged.
| region = attribute('region') | ||
|
|
||
| control "gcloud" do | ||
| title "GKE " |
There was a problem hiding this comment.
No tests will be added for now.
marko7460
force-pushed
the
database_encryption
branch
from
f74d2d6
to
fbdf65c
Compare
marko7460
force-pushed
the
database_encryption
branch
3 times, most recently
from
1d25fb3
to
ddf8ffd
Compare
… case. Updating documentation
marko7460
force-pushed
the
database_encryption
branch
from
209d0a4
to
b294685
Compare
database_encryptionvariable that enables Application level Secrets Encryption as described here: https://cloud.google.com/kubernetes-engine/docs/how-to/encrypting-secrets