-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add island-cluster example #1918
Merged
bharathkkb
merged 5 commits into
terraform-google-modules:master
from
nvnmandadhi:island-cluster-submodule
Apr 4, 2024
Merged
chore: add island-cluster example #1918
bharathkkb
merged 5 commits into
terraform-google-modules:master
from
nvnmandadhi:island-cluster-submodule
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvnmandadhi
force-pushed
the
island-cluster-submodule
branch
from
April 1, 2024 15:51
4d58cad
to
a1793cd
Compare
/gcbrun |
gtsorbo
changed the title
add island-cluster submodule and an example
feat: add island-cluster submodule and an example
Apr 2, 2024
bharathkkb
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @nvnmandadhi
nvnmandadhi
force-pushed
the
island-cluster-submodule
branch
from
April 3, 2024 20:47
a1793cd
to
8402f09
Compare
nvnmandadhi
changed the title
feat: add island-cluster submodule and an example
feat: add island-cluster example
Apr 3, 2024
nvnmandadhi
force-pushed
the
island-cluster-submodule
branch
from
April 3, 2024 20:55
8402f09
to
27ce085
Compare
bharathkkb
reviewed
Apr 4, 2024
nvnmandadhi
force-pushed
the
island-cluster-submodule
branch
5 times, most recently
from
April 4, 2024 16:50
ada94b7
to
9c98e48
Compare
nvnmandadhi
force-pushed
the
island-cluster-submodule
branch
from
April 4, 2024 16:56
9c98e48
to
31c5f2f
Compare
bharathkkb
approved these changes
Apr 4, 2024
bharathkkb
changed the title
feat: add island-cluster example
chore: add island-cluster example
Apr 4, 2024
bharathkkb
merged commit Apr 4, 2024
e711adb
into
terraform-google-modules:master
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example to create an island-cluster, this allows reusing the same IP address space for multiple clusters in a single project.