Add support for cluster resource_labels #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev25
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
approved these changes
Jul 19, 2019
morgante
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.terraform.io/docs/providers/google/r/container_cluster.html#resource_labels
Add support for GCE resource labels, compatible with Terraform 0.12
Tested locally with an existing cluster. There is a existing PR from a few months ago #81 which more or less does the same thing, i can cherry pick those integration tests cases if preferred?