Add 'grant_registry_access' variable to add 'storage.objectViewer'-role to SA #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpalamarchuk
force-pushed
the
add_storage_viewer_role_to_sa
branch
from
4163eff
to
7f8fa9e
Compare
paulpalamarchuk
changed the title
sa_grant_gcs_access variable to add storage.objectViewer-role to SA
|
@morgante @aaron-lane can you cleanup CI server please Error installing provider "google": write /tmp/getter323505370/archive: no space left on device. |
paulpalamarchuk
force-pushed
the
add_storage_viewer_role_to_sa
branch
from
7f8fa9e
to
c24149e
Compare
kopachevsky
reviewed
Aug 16, 2019
paulpalamarchuk
force-pushed
the
add_storage_viewer_role_to_sa
branch
from
c24149e
to
d893d5c
Compare
ingwarr
previously approved these changes
Aug 16, 2019
|
@paulpalamarchuk Let's call the variable |
paulpalamarchuk
force-pushed
the
add_storage_viewer_role_to_sa
branch
from
d893d5c
to
8ceea77
Compare
paulpalamarchuk
changed the title
sa_grant_gcs_access variable to add storage.objectViewer-role to SA
@morgante Variable name updated. |
ingwarr
previously approved these changes
Aug 16, 2019
paulpalamarchuk
force-pushed
the
add_storage_viewer_role_to_sa
branch
from
8ceea77
to
5751d4c
Compare
kopachevsky
previously approved these changes
Aug 19, 2019
ingwarr
previously approved these changes
Aug 20, 2019
paulpalamarchuk
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
* Added `grant_registry_access` variable to grant `roles/storage.objectViewer` to created SA (Fixes terraform-google-modules#229)
paulpalamarchuk
dismissed stale reviews from ingwarr and kopachevsky
via
31cb015
paulpalamarchuk
force-pushed
the
add_storage_viewer_role_to_sa
branch
from
b2081e1
to
31cb015
Compare
ingwarr
previously approved these changes
Aug 20, 2019
morgante
previously approved these changes
Aug 22, 2019
morgante
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grant_registry_accessvariable to grantroles/storage.objectViewerto created SA (Fixes Grant storage viewer to created service accounts #229)