Added support for resource usage export config #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulpalamarchuk
commented
Aug 19, 2019
•
paulpalamarchuk
commented
- Based on PR Added check for beta feature field istio_enabled #230
- Add support for beta feature resource_usage_export_config (Fixes add support for beta feature resource_usage_export_config #232)
paulpalamarchuk
force-pushed
the
add_check_for_beta_feature_fields
branch
from
48826ff
to
64ea79f
Compare
paulpalamarchuk
force-pushed
the
add_check_for_beta_feature_fields
branch
from
64ea79f
to
0b3826d
Compare
paulpalamarchuk
force-pushed
the
add_check_for_beta_feature_fields
branch
3 times, most recently
from
70111e5
to
425729c
Compare
ingwarr
previously approved these changes
Aug 20, 2019
ingwarr
reviewed
Aug 20, 2019
|
We have separate request for beta fields in PR #228 |
kopachevsky
previously approved these changes
Aug 21, 2019
nick4fake
suggested changes
Aug 21, 2019
paulpalamarchuk
dismissed stale reviews from kopachevsky and ingwarr
via
1e3e71c
paulpalamarchuk
force-pushed
the
add_check_for_beta_feature_fields
branch
from
425729c
to
1e3e71c
Compare
paulpalamarchuk
changed the title
paulpalamarchuk
force-pushed
the
add_check_for_beta_feature_fields
branch
from
1e3e71c
to
c578738
Compare
nick4fake
reviewed
Aug 21, 2019
paulpalamarchuk
force-pushed
the
add_check_for_beta_feature_fields
branch
5 times, most recently
from
8cbc1d0
to
6db1307
Compare
ingwarr
previously approved these changes
Aug 21, 2019
paulpalamarchuk
force-pushed
the
add_check_for_beta_feature_fields
branch
2 times, most recently
from
82f793a
to
3b28732
Compare
added optional field lookup and resource usage export config changed to dataset_id revert examples fixed bug where resource_usage_export_dataset_id was being set even if empty string check for null
* Based on PR terraform-google-modules#230 * Add support for beta feature resource_usage_export_config (Fixes terraform-google-modules#232)
paulpalamarchuk
force-pushed
the
add_check_for_beta_feature_fields
branch
from
3b28732
to
99d8e37
Compare
paulpalamarchuk
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
previously approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.