Add flag to enable GKE Sandbox #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpalamarchuk
force-pushed
the
add_sandbox_config_param
branch
from
3efa2f3
to
aa70e8a
Compare
paulpalamarchuk
requested review from
nick4fake,
ivankorn,
kopachevsky and
ingwarr
|
Do we handle this ? DOn't sure it's on our side, but still |
|
Also, according to this https://cloud.google.com/kubernetes-engine/docs/how-to/sandbox-pods |
kopachevsky
reviewed
Aug 23, 2019
|
@kopachevsky thank you for the notice. I will update PR |
paulpalamarchuk
force-pushed
the
add_sandbox_config_param
branch
from
aa70e8a
to
e88d26b
Compare
ingwarr
previously approved these changes
Aug 23, 2019
ivankorn
previously approved these changes
Aug 23, 2019
* Add `sandbox_enabled` variable to use GKE Sandbox (Fixes terraform-google-modules#240)
paulpalamarchuk
force-pushed
the
add_sandbox_config_param
branch
from
e88d26b
to
2ccc0f3
Compare
paulpalamarchuk
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
previously approved these changes
Aug 28, 2019
morgante
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sandbox_enabledvariable to use GKE Sandbox (Fixes Add sandbox flag for node-pools #240)