Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wait-for-cluster.sh] Update the script in all submodules. #285

Merged
merged 4 commits into from
Oct 23, 2019
Merged

[wait-for-cluster.sh] Update the script in all submodules. #285

merged 4 commits into from
Oct 23, 2019

Conversation

omazin
Copy link
Contributor

@omazin omazin commented Oct 18, 2019

Follows up #284

@paulpalamarchuk
Copy link
Contributor

@omazin please update sh-script in autogen directory (autogen/scripts/wait-for-cluster.sh)

@omazin
Copy link
Contributor Author

omazin commented Oct 18, 2019

@paulpalamarchuk updated

@omazin
Copy link
Contributor Author

omazin commented Oct 21, 2019 •
edited

Updated, without the fix it would throw the following error when terraform apply / destroy:

module.gke.null_resource.wait_for_cluster (local-exec): ERROR: (gcloud.container.clusters.list) ResponseError: code=403, message=Required "container.clusters.list" permission(s) for "projects/your-project-id".

@aaron-lane aaron-lane added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Oct 22, 2019
aaron-lane
aaron-lane approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @omazin!

@aaron-lane
Copy link
Contributor

Merging since the test timeout will be addressed with #292 and this solves a regression in the generation diff.

@aaron-lane aaron-lane merged commit 8ed6bfc into terraform-google-modules:master Oct 23, 2019
aaron-lane added a commit that referenced this pull request Oct 24, 2019
@aaron-lane
Add entry for 5.1.0 to CHANGELOG
2438e71 
Add entries:
- #282 
- #284 
- #285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-lane aaron-lane aaron-lane approved these changes

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@morgante morgante Awaiting requested review from morgante

Assignees

@aaron-lane aaron-lane

@omazin omazin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@omazin @paulpalamarchuk @aaron-lane