Tying identity namespace output to successful cluster creation. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevensen
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
suggested changes
Nov 1, 2019
kevensen
force-pushed
the
workload-identity-output
branch
from
9729231
to
a79537c
Compare
morgante
approved these changes
Nov 1, 2019
|
@morgante Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring workload identity, there is the possibility that when creating an IAM binding, Terraform attempts to create the binding, before the workload identity is configured by GKE. This PR creates a tighter dependency between the creation of a GKE cluster and the availability of the workload identity.
This is the first step in addressing forseti-security/terraform-google-forseti#298.