Support for setting node_locations on node pools #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
|
Don't mean to rush, but was wondering what is the status on this? When could we expect this to be merged? |
|
@DanielWozniak I think we're waiting for tests to pass. @bharathkkb Could you take a look? |
|
@morgante I'll try re running the tests. It was failing destroy stage of a different example. |
|
Looks like the checks are passing, could one of the approvers please take a look? |
morgante
approved these changes
Nov 11, 2019
morgante
changed the title
|
Thanks guys, appreciate you putting this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #290
Add support for node_locations to set locations for individual node pools.