Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node pool metadata key value pairs #52

Merged
merged 7 commits into from
Jan 8, 2019

Conversation

Jberlinsky
Copy link
Contributor

Expands on #47 with test coverage.

@Jberlinsky Jberlinsky changed the title Node pool metadata key value pairs [WIP] Node pool metadata key value pairs Jan 3, 2019
@Jberlinsky Jberlinsky self-assigned this Jan 3, 2019
@Jberlinsky Jberlinsky changed the title [WIP] Node pool metadata key value pairs Node pool metadata key value pairs Jan 3, 2019
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small (non-blocking) suggestion.

README.md Outdated Show resolved Hide resolved
@Jberlinsky Jberlinsky force-pushed the feature/czka-node-pool-metadata-key-value-pairs branch from 714c155 to be720e6 Compare January 5, 2019 04:06
@Jberlinsky Jberlinsky force-pushed the feature/czka-node-pool-metadata-key-value-pairs branch from 17908c9 to cd83d4b Compare January 5, 2019 06:42
aaron-lane
aaron-lane previously approved these changes Jan 7, 2019
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgante morgante merged commit a7122c3 into master Jan 8, 2019
@adrienthebo adrienthebo deleted the feature/czka-node-pool-metadata-key-value-pairs branch February 28, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants