Add initial_node_count var for node_pool block #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkubaczyk
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
approved these changes
Jan 9, 2019
morgante
reviewed
Jan 9, 2019
morgante
suggested changes
Jan 9, 2019
|
Test failures should be resolved by #62 |
morgante
previously approved these changes
Jan 9, 2019
aaron-lane
previously requested changes
Jan 9, 2019
There was a problem hiding this comment.
This needs to be rebased against master now that #62 is merged.
Co-Authored-By: mkubaczyk <kubaczyk@gmail.com>
|
@aaron-lane done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to extend the node_pool block parameters a bit and add optional, explicitly set initial_node_count for node pool. It assumes the min_count or 1 when not defined, so it doesn't affect anyone when not set.
We need this to start new node pool with predefined node count even when autoscaling minimal value is set lower, useful especially when adding new node pool as a reaction to increased traffic etc.
I added no tests. If there's anyone willing to write them since I haven't had a chance yet, please don't hesitate.