Drop explicit version from simple_zonal example #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienthebo
requested review from
aaron-lane,
Jberlinsky and
morgante
as code owners
Jberlinsky
previously approved these changes
Jan 29, 2019
The explicit version in the simple_zonal example is causing failures as 1.11.4-gke.13 has been dropped as a valid master version. This commit drops the explicit versions in the simple_zonal example; we can just use the latest version avilable.
adrienthebo
force-pushed
the
adrienthebo/simple_zonal_no_version
branch
from
847e847
to
0ab9631
Compare
aaron-lane
approved these changes
Feb 7, 2019
|
We should think about a way to test the behaviour of the version variables without the tests becoming brittle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit version in the simple_zonal example is causing failures as
1.11.4-gke.13 has been dropped as a valid master version. This commit
drops the explicit versions in the simple_zonal example; we can just use
the latest version avilable.