support terraform 0.12 #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The examples also need to be updated to support Terraform v0.12. @ivankorn Please go ahead and start a new PR which incorporates this one but also updates examples. |
itscaro
reviewed
Aug 16, 2019
| name = "${var.name}-http-proxy" | ||
| url_map = "${element(compact(concat(list(var.url_map), google_compute_url_map.default.*.self_link)), 0)}" | ||
| url_map = element( |
There was a problem hiding this comment.
maybe compact(concat(list(var.url_map), google_compute_url_map.default.*.self_link))[0]
itscaro
reviewed
Aug 16, 2019
| project = var.project | ||
| count = var.ssl ? 1 : 0 | ||
| name = "${var.name}-https-proxy" | ||
| url_map = element( |
There was a problem hiding this comment.
maybe compact(concat(list(var.url_map), google_compute_url_map.default.*.self_link))[0]
itscaro
reviewed
Aug 16, 2019
| description = "Map backend indices to list of backend maps." | ||
| type = "map" | ||
| type = map |
There was a problem hiding this comment.
IMO, this should become a list as backend_params is a list, but this is not what this PR is about :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
terraform 0.12upgradecommand of terraform 0.12.3 to upgrade syntax of this modulebackends(the above command set it tomap(string), which is not correct)Reference
Fixes #49