Add support for Terraform 0.12 #52
Merged
Commits on Jun 27, 2019
Commits on Aug 16, 2019
Commits on Aug 22, 2019
-
Add support for Terraform 0.12 terraform-google-modules#51
- 'examples/basic' migrated and provisioned ``` $ terraform apply -auto-approve module.mig1_template.data.google_compute_image.image_family: Refreshing state... module.mig2.data.google_compute_zones.available: Refreshing state... module.mig2_template.data.google_compute_image.image_family: Refreshing state... module.mig1.data.google_compute_zones.available: Refreshing state... module.mig2_template.data.google_compute_image.image: Refreshing state... module.mig1_template.data.google_compute_image.image: Refreshing state... data.template_file.group-startup-script: Refreshing state... google_compute_network.default: Creating... module.gce-lb-http.google_compute_http_health_check.default[0]: Creating... module.gce-lb-http.google_compute_global_address.default: Creating... module.gce-lb-http.google_compute_http_health_check.default[0]: Creation complete after 4s [id=mig-basic-lb-backend-0] module.gce-lb-http.google_compute_global_address.default: Creation complete after 4s [id=mig-basic-lb-address] google_compute_network.default: Still creating... [10s elapsed] google_compute_network.default: Still creating... [20s elapsed] google_compute_network.default: Creation complete after 28s [id=mig-basic] google_compute_subnetwork.group1: Creating... google_compute_subnetwork.group2: Creating... google_compute_subnetwork.group1: Still creating... [10s elapsed] google_compute_subnetwork.group2: Still creating... [10s elapsed] google_compute_subnetwork.group2: Creation complete after 17s [id=us-east1/mig-basic-group2] module.mig2_template.google_compute_instance_template.tpl: Creating... google_compute_subnetwork.group1: Still creating... [20s elapsed] module.mig2_template.google_compute_instance_template.tpl: Creation complete after 5s [id=mig-basic-group2-20190822225210380000000001] module.mig2.google_compute_region_instance_group_manager.mig: Creating... google_compute_subnetwork.group1: Creation complete after 28s [id=us-west1/mig-basic-group1] google_compute_subnetwork.lb: Creating... module.mig1_template.google_compute_instance_template.tpl: Creating... module.mig2.google_compute_region_instance_group_manager.mig: Still creating... [10s elapsed] module.mig1_template.google_compute_instance_template.tpl: Creation complete after 5s [id=mig-basic-group1-20190822225221497600000002] module.gce-lb-http.google_compute_firewall.default-hc[0]: Creating... module.mig1.google_compute_region_instance_group_manager.mig: Creating... google_compute_subnetwork.lb: Still creating... [10s elapsed] module.gce-lb-http.google_compute_firewall.default-hc[0]: Creation complete after 8s [id=mig-basic-lb-hc-0] module.mig2.google_compute_region_instance_group_manager.mig: Still creating... [20s elapsed] module.mig1.google_compute_region_instance_group_manager.mig: Still creating... [10s elapsed] google_compute_subnetwork.lb: Still creating... [20s elapsed] module.mig1.google_compute_region_instance_group_manager.mig: Creation complete after 18s [id=gl-ivankorniienko-seed/us-west1/mig-basic-group1-mig] module.mig2.google_compute_region_instance_group_manager.mig: Creation complete after 29s [id=gl-ivankorniienko-seed/us-east1/mig-basic-group2-mig] module.gce-lb-http.google_compute_backend_service.default[0]: Creating... google_compute_subnetwork.lb: Creation complete after 29s [id=us-west1/mig-basic-lb] module.gce-lb-http.google_compute_backend_service.default[0]: Creation complete after 9s [id=mig-basic-lb-backend-0] module.gce-lb-http.google_compute_url_map.default[0]: Creating... module.gce-lb-http.google_compute_url_map.default[0]: Creation complete after 4s [id=mig-basic-lb-url-map] module.gce-lb-http.google_compute_target_http_proxy.default[0]: Creating... module.gce-lb-http.google_compute_target_http_proxy.default[0]: Creation complete after 4s [id=mig-basic-lb-http-proxy] module.gce-lb-http.google_compute_global_forwarding_rule.http[0]: Creating... module.gce-lb-http.google_compute_global_forwarding_rule.http[0]: Still creating... [10s elapsed] module.gce-lb-http.google_compute_global_forwarding_rule.http[0]: Creation complete after 18s [id=mig-basic-lb] Apply complete! Resources: 15 added, 0 changed, 0 destroyed. Outputs: load-balancer-ip = 35.244.166.214 ```
Commits on Sep 2, 2019
-
Migrated examples (migrated to 0.12 compatible modules, migrated to 0…
….12 syntax, interpolation, dynamic blocks, etc): - examples/basic -> examples/multi-mig-http-lb - examples/http-nat-gateway -> examples/mig-nat-http-lb - examples/https-content -> examples/multi-backend-multi-mig-bucket-https-lb - examples/multiple-certs (similar to above, but with multiple certs) ref: terraform-google-modules#51
Commits on Sep 5, 2019
-
Migrated examples/shared-vpc to 0.12 syntax
- migrated the example code to 0.12 syntax and 0.12 compatible modules - slightly modified core module logic to handle shared vpc specific case as well - switched to using common symlink for startup script template - added provisioning for shared network, subnetwork, router and cloud nat Please note: Due to bug/limitation of instance_template sumbodule(reported here terraform-google-modules/terraform-google-vm#29), the shared vpc example is currently broken and fails on creating an instance template with shared network: ``` $ terraform apply -auto-approve module.cloud-nat.random_string.name_suffix: Refreshing state... [id=t24x9w] data.template_file.group-startup-script: Refreshing state... module.gce-lb-http.google_compute_firewall.default-hc[0]: Refreshing state... [id=group-http-lb-hc-0] module.gce-lb-http.google_compute_http_health_check.default[0]: Refreshing state... [id=group-http-lb-backend-0] module.gce-lb-http.google_compute_global_address.default: Refreshing state... [id=group-http-lb-address] google_compute_network.default: Refreshing state... [id=shared-vpc-lb-http] module.mig.data.google_compute_zones.available: Refreshing state... module.mig_template.data.google_compute_image.image_family: Refreshing state... module.mig_template.data.google_compute_image.image: Refreshing state... google_compute_router.default: Refreshing state... [id=us-central1/lb-http-router] google_compute_subnetwork.default: Refreshing state... [id=us-central1/shared-vpc-lb-http] module.cloud-nat.google_compute_router_nat.main: Refreshing state... [id=us-central1/lb-http-router/cloud-nat-lb-http-router] module.mig_template.google_compute_instance_template.tpl: Creating... Error: Error creating instance template: googleapi: Error 400: Invalid value for field 'resource.properties.networkInterfaces[0].subnetwork': 'projects/gl-ik-shared/regions/us-central1/subnetworks/shared-vpc-lb-http'. Cross-project references for this resource are not allowed., invalid on .terraform/modules/mig_template/terraform-google-modules-terraform-google-vm-cb3d6cc/modules/instance_template/main.tf line 51, in resource "google_compute_instance_template" "tpl": 51: resource "google_compute_instance_template" "tpl" { ```
Commits on Sep 6, 2019
-
Migrated from [count.index] to for_each, migrated to newer health check
ref: terraform-google-modules#51 ``` [18:54][user@host:~/workspace/google/terraform-google-lb-http/examples/mig-nat-http-lb]$ terraform apply -auto-approve module.mig.data.google_compute_zones.available: Refreshing state... module.mig_template.data.google_compute_image.image: Refreshing state... module.mig_template.data.google_compute_image.image_family: Refreshing state... data.template_file.group-startup-script: Refreshing state... module.cloud-nat.random_string.name_suffix: Creating... module.cloud-nat.random_string.name_suffix: Creation complete after 0s [id=jb4pjk] google_compute_network.default: Creating... module.gce-lb-http.google_compute_global_address.default: Creating... module.gce-lb-http.google_compute_health_check.default[0]: Creating... module.gce-lb-http.google_compute_health_check.default[0]: Creation complete after 5s [id=mig-http-lb-http-80-6666cd76] module.gce-lb-http.google_compute_global_address.default: Creation complete after 5s [id=mig-http-lb-address] google_compute_network.default: Still creating... [10s elapsed] google_compute_network.default: Still creating... [20s elapsed] google_compute_network.default: Creation complete after 28s [id=tf-lb-http-mig-nat] google_compute_router.default: Creating... google_compute_subnetwork.default: Creating... module.gce-lb-http.google_compute_firewall.default["tf-lb-http-mig-nat"]: Creating... google_compute_router.default: Creation complete after 5s [id=us-west1/lb-http-router] module.cloud-nat.google_compute_router_nat.main: Creating... google_compute_subnetwork.default: Still creating... [10s elapsed] module.gce-lb-http.google_compute_firewall.default["tf-lb-http-mig-nat"]: Still creating... [10s elapsed] module.cloud-nat.google_compute_router_nat.main: Still creating... [10s elapsed] google_compute_subnetwork.default: Still creating... [20s elapsed] module.gce-lb-http.google_compute_firewall.default["tf-lb-http-mig-nat"]: Still creating... [20s elapsed] module.cloud-nat.google_compute_router_nat.main: Creation complete after 17s [id=us-west1/lb-http-router/cloud-nat-lb-http-router] module.gce-lb-http.google_compute_firewall.default["tf-lb-http-mig-nat"]: Creation complete after 28s [id=mig-http-lb-tf-lb-http-mig-nat-hc] google_compute_subnetwork.default: Still creating... [30s elapsed] google_compute_subnetwork.default: Creation complete after 39s [id=us-west1/tf-lb-http-mig-nat] module.mig_template.google_compute_instance_template.tpl: Creating... module.mig_template.google_compute_instance_template.tpl: Creation complete after 4s [id=tf-lb-http-mig-nat-20190906155713028900000001] module.mig.google_compute_region_instance_group_manager.mig: Creating... module.mig.google_compute_region_instance_group_manager.mig: Still creating... [10s elapsed] module.mig.google_compute_region_instance_group_manager.mig: Still creating... [20s elapsed] module.mig.google_compute_region_instance_group_manager.mig: Creation complete after 29s [id=gl-ivankorniienko-seed-251912/us-west1/tf-lb-http-mig-nat-mig] module.gce-lb-http.google_compute_backend_service.default["0"]: Creating... module.gce-lb-http.google_compute_backend_service.default["0"]: Creation complete after 9s [id=mig-http-lb-backend-0] module.gce-lb-http.google_compute_url_map.default[0]: Creating... module.gce-lb-http.google_compute_url_map.default[0]: Creation complete after 4s [id=mig-http-lb-url-map] module.gce-lb-http.google_compute_target_http_proxy.default[0]: Creating... module.gce-lb-http.google_compute_target_http_proxy.default[0]: Creation complete after 4s [id=mig-http-lb-http-proxy] module.gce-lb-http.google_compute_global_forwarding_rule.http[0]: Creating... module.gce-lb-http.google_compute_global_forwarding_rule.http[0]: Creation complete after 10s [id=mig-http-lb] Apply complete! Resources: 14 added, 0 changed, 0 destroyed. Outputs: load-balancer-ip = 35.190.121.34 [18:58][user@host:~/workspace/google/terraform-google-lb-http/examples/mig-nat-http-lb]$ less plat.output.txt [19:05][user@host:~/workspace/google/terraform-google-lb-http/examples/mig-nat-http-lb]$ ./test.sh + set -e ++ terraform output load-balancer-ip + URL=http://35.190.121.34 + status=0 + count=0 + [[ 0 -lt 720 ]] + [[ 0 -ne 200 ]] + echo 'INFO: Waiting for load balancer...' INFO: Waiting for load balancer... ++ curl -sf -m 5 -o /dev/null -w '%{http_code}' http://35.190.121.34 + status=200 + (( count=count+1 )) + sleep 5 + [[ 1 -lt 720 ]] + [[ 200 -ne 200 ]] + [[ 1 -lt 720 ]] + echo 'INFO: PASS' INFO: PASS ``` ``` [18:54][user@host:~/workspace/google/terraform-google-lb-http/examples/multi-mig-http-lb]$ terraform apply -auto-approve module.mig2.data.google_compute_zones.available: Refreshing state... module.mig2_template.data.google_compute_image.image_family: Refreshing state... module.mig1_template.data.google_compute_image.image_family: Refreshing state... module.mig2_template.data.google_compute_image.image: Refreshing state... module.mig1_template.data.google_compute_image.image: Refreshing state... module.mig1.data.google_compute_zones.available: Refreshing state... data.template_file.group-startup-script: Refreshing state... module.cloud-nat-group1.random_string.name_suffix: Creating... module.cloud-nat-group2.random_string.name_suffix: Creating... module.cloud-nat-group1.random_string.name_suffix: Creation complete after 0s [id=mds1om] module.cloud-nat-group2.random_string.name_suffix: Creation complete after 0s [id=971f2q] google_compute_network.default: Creating... module.gce-lb-http.google_compute_global_address.default: Creating... module.gce-lb-http.google_compute_health_check.default[0]: Creating... module.gce-lb-http.google_compute_global_address.default: Creation complete after 5s [id=multi-mig-lb-http-address] module.gce-lb-http.google_compute_health_check.default[0]: Creation complete after 5s [id=multi-mig-lb-http-http-80-6666cd76] google_compute_network.default: Still creating... [10s elapsed] google_compute_network.default: Creation complete after 17s [id=multi-mig-lb-http] google_compute_router.group1: Creating... google_compute_subnetwork.group2: Creating... google_compute_subnetwork.group1: Creating... google_compute_router.group2: Creating... google_compute_router.group2: Creation complete after 4s [id=us-east1/multi-mig-lb-http-gw-group2] module.cloud-nat-group2.google_compute_router_nat.main: Creating... google_compute_router.group1: Creation complete after 4s [id=us-west1/multi-mig-lb-http-gw-group1] module.cloud-nat-group1.google_compute_router_nat.main: Creating... module.gce-lb-http.google_compute_firewall.default["multi-mig-lb-http"]: Creating... google_compute_subnetwork.group2: Still creating... [10s elapsed] google_compute_subnetwork.group1: Still creating... [10s elapsed] module.cloud-nat-group2.google_compute_router_nat.main: Still creating... [10s elapsed] module.cloud-nat-group1.google_compute_router_nat.main: Still creating... [10s elapsed] module.gce-lb-http.google_compute_firewall.default["multi-mig-lb-http"]: Still creating... [10s elapsed] google_compute_subnetwork.group2: Still creating... [20s elapsed] google_compute_subnetwork.group1: Still creating... [20s elapsed] module.gce-lb-http.google_compute_firewall.default["multi-mig-lb-http"]: Creation complete after 17s [id=multi-mig-lb-http-multi-mig-lb-http-hc] module.cloud-nat-group2.google_compute_router_nat.main: Creation complete after 17s [id=us-east1/multi-mig-lb-http-gw-group2/multi-mig-lb-http-cloud-nat-group2] module.cloud-nat-group1.google_compute_router_nat.main: Creation complete after 18s [id=us-west1/multi-mig-lb-http-gw-group1/multi-mig-lb-http-cloud-nat-group1] google_compute_subnetwork.group2: Creation complete after 27s [id=us-east1/multi-mig-lb-http-group2] module.mig2_template.google_compute_instance_template.tpl: Creating... google_compute_subnetwork.group1: Creation complete after 27s [id=us-west1/multi-mig-lb-http-group1] module.mig1_template.google_compute_instance_template.tpl: Creating... module.mig2_template.google_compute_instance_template.tpl: Creation complete after 4s [id=multi-mig-lb-http-group2-20190906155604990200000001] module.mig2.google_compute_region_instance_group_manager.mig: Creating... module.mig1_template.google_compute_instance_template.tpl: Creation complete after 5s [id=multi-mig-lb-http-group1-20190906155605140900000002] module.mig1.google_compute_region_instance_group_manager.mig: Creating... module.mig2.google_compute_region_instance_group_manager.mig: Still creating... [10s elapsed] module.mig1.google_compute_region_instance_group_manager.mig: Still creating... [10s elapsed] module.mig2.google_compute_region_instance_group_manager.mig: Creation complete after 19s [id=gl-ivankorniienko-seed-251912/us-east1/multi-mig-lb-http-group2-mig] module.mig1.google_compute_region_instance_group_manager.mig: Creation complete after 19s [id=gl-ivankorniienko-seed-251912/us-west1/multi-mig-lb-http-group1-mig] module.gce-lb-http.google_compute_backend_service.default["0"]: Creating... module.gce-lb-http.google_compute_backend_service.default["0"]: Still creating... [10s elapsed] module.gce-lb-http.google_compute_backend_service.default["0"]: Creation complete after 17s [id=multi-mig-lb-http-backend-0] module.gce-lb-http.google_compute_url_map.default[0]: Creating... module.gce-lb-http.google_compute_url_map.default[0]: Creation complete after 4s [id=multi-mig-lb-http-url-map] module.gce-lb-http.google_compute_target_http_proxy.default[0]: Creating... module.gce-lb-http.google_compute_target_http_proxy.default[0]: Creation complete after 4s [id=multi-mig-lb-http-http-proxy] module.gce-lb-http.google_compute_global_forwarding_rule.http[0]: Creating... module.gce-lb-http.google_compute_global_forwarding_rule.http[0]: Creation complete after 9s [id=multi-mig-lb-http] Apply complete! Resources: 20 added, 0 changed, 0 destroyed. Outputs: load-balancer-ip = 35.190.47.152 [18:57][user@host:~/workspace/google/terraform-google-lb-http/examples/multi-mig-http-lb]$ ./test.sh + set -e ++ terraform output load-balancer-ip + URL=http://35.190.47.152 + status=0 + count=0 + [[ 0 -lt 720 ]] + [[ 0 -ne 200 ]] + echo 'INFO: Waiting for load balancer...' INFO: Waiting for load balancer... ++ curl -sf -m 5 -o /dev/null -w '%{http_code}' http://35.190.47.152 + status=200 + (( count=count+1 )) + sleep 5 + [[ 1 -lt 720 ]] + [[ 200 -ne 200 ]] + [[ 1 -lt 720 ]] + echo 'INFO: PASS' INFO: PASS [19:14][user@host:~/workspace/google/terraform-google-lb-http/examples/multi-mig-http-lb]$ ```
Commits on Sep 10, 2019
-
Revert "Migrated from [count.index] to for_each, migrated to newer he…
…alth check" This reverts commit 26efad9.
Commits on Sep 11, 2019
-
- Restricted variables value types - Adjusted expression for determining firwall project. Previous version worked for TF 0.12.7, while this works on both 0.12.7 and 0.12.8 Example of funny behaviour: ``` > var.firewall_projects [ "default", ] > var.firewall_projects == ["default"] false > ["default"] == ["default"] true > var.firewall_projects == ["default"] false > var.firewall_projects[0] default > var.firewall_projects == ["default"] false > var.firewall_projects[0] == ["default"][0] true > length(var.firewall_projects) == length(["default"]) true > ``` - Adjusted backend_service output with a for loop as eventually `default.*.self_link` fails with list of maps. 4 examples passing: - mig-nat-http-lb - multiple-certs - multi-mig-http-lb - mig-nat-http-lb Shared VPC still blocked by module vm bug. gke migration to be finalized.
-
Migrated https-gke example to TF 0.12
Please, note: the `named_port` module is not migrated to 0.12: "github.com/danisla/terraform-google-named-ports". Test Passed: ``` [23:29][user@host:~/workspace/google/terraform-google-lb-http/examples/https-gke]$ terraform apply -auto-approve data.google_client_config.current: Refreshing state... tls_private_key.example: Creating... random_id.assets-bucket: Creating... random_id.assets-bucket: Creation complete after 0s [id=Gbw] google_storage_bucket.assets: Creating... module.gce-lb-https.google_compute_global_address.default: Creating... module.gce-lb-https.google_compute_http_health_check.default[0]: Creating... module.gce-lb-https.google_compute_firewall.default-hc[0]: Creating... tls_private_key.example: Creation complete after 0s [id=76d79f128ff4de6bfbc481304835e7d55539e3ae] tls_self_signed_cert.example: Creating... tls_self_signed_cert.example: Creation complete after 0s [id=15848693639361799899384461993161024875] module.gce-lb-https.google_compute_ssl_certificate.default[0]: Creating... google_storage_bucket.assets: Creation complete after 2s [id=gl-ivankorniienko-seed-251912-lb-assets-19bc] google_compute_backend_bucket.assets: Creating... google_storage_bucket_object.image: Creating... google_storage_bucket_object.image: Creation complete after 1s [id=gl-ivankorniienko-seed-251912-lb-assets-19bc-assets/gcp-logo.svg] google_storage_object_acl.image-acl: Creating... google_storage_object_acl.image-acl: Creation complete after 1s [id=assets/gcp-logo.svg-acl] module.gce-lb-https.google_compute_http_health_check.default[0]: Creation complete after 5s [id=tf-lb-https-gke-backend-0] module.gce-lb-https.google_compute_backend_service.default[0]: Creating... module.gce-lb-https.google_compute_global_address.default: Creation complete after 5s [id=tf-lb-https-gke-address] module.gce-lb-https.google_compute_ssl_certificate.default[0]: Creation complete after 5s [id=tf-lb-https-gke-certificate-20190911203351172300000001] google_compute_backend_bucket.assets: Creation complete after 4s [id=gl-ivankorniienko-seed-251912-lb-assets-19bc] module.gce-lb-https.google_compute_firewall.default-hc[0]: Still creating... [10s elapsed] module.gce-lb-https.google_compute_backend_service.default[0]: Creation complete after 8s [id=tf-lb-https-gke-backend-0] google_compute_url_map.my-url-map: Creating... google_compute_url_map.my-url-map: Creation complete after 4s [id=tf-lb-https-gke] module.gce-lb-https.google_compute_target_http_proxy.default[0]: Creating... module.gce-lb-https.google_compute_target_https_proxy.default[0]: Creating... module.gce-lb-https.google_compute_firewall.default-hc[0]: Creation complete after 17s [id=tf-lb-https-gke-hc-0] module.gce-lb-https.google_compute_target_http_proxy.default[0]: Creation complete after 5s [id=tf-lb-https-gke-http-proxy] module.gce-lb-https.google_compute_global_forwarding_rule.http[0]: Creating... module.gce-lb-https.google_compute_target_https_proxy.default[0]: Creation complete after 5s [id=tf-lb-https-gke-https-proxy] module.gce-lb-https.google_compute_global_forwarding_rule.https[0]: Creating... module.gce-lb-https.google_compute_global_forwarding_rule.http[0]: Still creating... [10s elapsed] module.gce-lb-https.google_compute_global_forwarding_rule.https[0]: Still creating... [10s elapsed] module.gce-lb-https.google_compute_global_forwarding_rule.http[0]: Creation complete after 17s [id=tf-lb-https-gke] module.gce-lb-https.google_compute_global_forwarding_rule.https[0]: Creation complete after 18s [id=tf-lb-https-gke-https] Apply complete! Resources: 17 added, 0 changed, 0 destroyed. Outputs: load-balancer-ip = 35.190.47.152 [23:34][user@host:~/workspace/google/terraform-google-lb-http/examples/https-gke]$ ./test.sh + set -e ++ terraform output load-balancer-ip + URL=https://35.190.47.152 + status=0 + count=0 + [[ 0 -lt 720 ]] + [[ 0 -ne 200 ]] + echo 'INFO: Waiting for load balancer...' INFO: Waiting for load balancer... ++ curl -sfk -m 5 -o /dev/null -w '%{http_code}' https://35.190.47.152 + status=200 + (( count=count+1 )) + sleep 5 + [[ 1 -lt 720 ]] + [[ 200 -ne 200 ]] + [[ 1 -lt 720 ]] + echo 'INFO: PASS. Load balancer is ready.' INFO: PASS. Load balancer is ready. [00:29][user@host:~/workspace/google/terraform-google-lb-http/examples/https-gke]$ ```
Commits on Sep 30, 2019
-
- Removed trailing whitespaces - Migrated to 0.12 TF syntax in README - Corrected shell variables - Moved ouptus and variables into separated files as discussed terraform-google-modules#52 (comment) - Simplified firewall rules logic as discussed terraform-google-modules#52 (comment) - Adjusted provider configuration as discussed terraform-google-modules#52 (comment) - Replaced not migrated module call with local_exec in null_resource as discussed terraform-google-modules#52 (comment) - Re-formatted main module output as discussed terraform-google-modules#52 (comment) - Re-named https-gke example input variable as discussed terraform-google-modules#52 (comment) - Enforced backend params validation as discussed https://github.com/terraform-google-modules/terraform-google-lb-http/pull/52/files/42602b96de3e1eaa0f974e3f613a228edf64d322#r329202314
-
I incorrectly identified this a as a string rather than a number.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.